1851006 - Missing search engine suggestion

Status: VERIFIED FIXED

(Firefox for Android :: Search, defect)

Description

[Roger Yang [:royang]]

As an requirement of https://github.com/mozilla-mobile/fenix/issues/16044,
Fenix should suggest search engine specific search when the search text matches an search engine name.

Currently these search engine suggestions aren't displayed.
This should go at the top, above the "Google Search" heading but it should not have it's own heading.

Comment 1

[Roger Yang [:royang]]

Attachment: 96536672-1396cb80-12f1-11eb-9ef4-3530da169b70.png

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

We will want to uplift this along with Bug 1851012 when this is resolved and both bugs are QA verified.

Comment 3

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1851006 - SearchEngineSuggestionProvider should always be added to the provider list. (#3528)

Comment 4

[BMO Github Automation]

Authored by https://github.com/iorgamgabriel
https://github.com/mozilla-mobile/firefox-android/commit/81d002ade2db9fac3af138754c52d04ca9dc99bd
[main] Bug 1851006 - SearchEngineSuggestionProvider should always be added to the provider list.

Comment 5

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:giorga, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox118 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment 2 suggests that we want to uplift this to 118?

Comment 7

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1851006 - SearchEngineSuggestionProvider should always be added to the provider list. (backport #3528) (#3583)

Comment 8

[Iorga Gabriel]

Comment on attachment 9352424 [details] [review]
[mozilla-mobile/firefox-android] Bug 1851006 - SearchEngineSuggestionProvider should always be added to the provider list. (backport #3528) (#3583)

Beta/Release Uplift Approval Request

• User impact if declined: The user will not see the search engine suggestions when the search text matches a search engine name.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: When the user's search text matches a search engine name, a search engine suggestion should appear.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed:
• Is Android affected?: Yes

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9352424 [details] [review]
[mozilla-mobile/firefox-android] Bug 1851006 - SearchEngineSuggestionProvider should always be added to the provider list. (backport #3528) (#3583)

v118 is on beta

Comment 10

[Gabriel Luong [:gl] (ΦωΦ)]

Let's wait until this is verified before uplifting.

Comment 11

[Adina Petridean QA [:apetridean]]

Verified as fixed on the Fenix Nightly 119.0a1 from 9/11 with Google Pixel 7 Pro ( Android 14) and Motorola Moto G9 plus (Android 11).

Comment 12

[Adina Petridean QA [:apetridean]]

Attachment: search.JPEG

Comment 13

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9352424 [details] [review]
[mozilla-mobile/firefox-android] Bug 1851006 - SearchEngineSuggestionProvider should always be added to the provider list. (backport #3528) (#3583)

Approved for 118.0b8, thanks.

Comment 14

[BMO Github Automation]

Authored by https://github.com/iorgamgabriel
https://github.com/mozilla-mobile/firefox-android/commit/6d314f5657333c10263e4b26858e60567842fcef
[releases_v118] Bug 1851006 - SearchEngineSuggestionProvider should always be added to the provider list.

Authored by https://github.com/pascalchevrel
https://github.com/mozilla-mobile/firefox-android/commit/6e36251ea649145c16b2ed3166cceed78d8fb4d2
[releases_v118] Merge pull request #3583 from mozilla-mobile/mergify/bp/releases_v118/pr-3528

Comment 15

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Beta 118.0b8 with Sony Xperia Z5 Premium (Android 7.1.1), Lenovo tablet M10 (Android 10), and Google Pixel 6 (Android 14).