Closed Bug 1851060 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 41752 - Refactor focus navigation tests

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
119 Branch
Tracking Status
firefox119 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 41752 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41752
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Refactor focus navigation tests

There was a very common pattern in these tests:

assert_focus_navigation_forward(elements);
elements.reverse();
assert_focus_navigation_backward(elements);

so I pulled this pattern out into a new function:

assert_focus_navigation_bidirectional(elements);

Note that there are two versions of the focus-utils.js utility, and
they work differently. The WPT version uses test_driver.Actions() and
is therefore async, while the non-WPT version uses eventSender and is
therefore sync.

This should not introduce any functional changes in these tests.

Change-Id: I90fc6718cfd1154523e12740218948e8f5f285b0
Reviewed-on: https://chromium-review.googlesource.com/4834580
WPT-Export-Revision: 621c57c861acc4a665cb76840fd9196cfd5d9da9

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d86aa57c86c0 [wpt PR 41752] - Refactor focus navigation tests, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
You need to log in before you can comment on or make changes to this bug.