1851071 - Intermittent OSX Cross Compiled gfx/thebes/gfxMacPlatformFontList.mm:427:15: error: unused variable 'kTextDisplayCrossover' [-Werror,-Wunused-const-variable]

Status: RESOLVED FIXED

(Core :: Graphics, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=427648693&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/EASHaF9_SfahNzThAHqgJQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2023-08-31T23:27:56.131Z] 23:27:56    ERROR -  /builds/worker/checkouts/gecko/gfx/thebes/gfxMacPlatformFontList.mm:427:15: error: unused variable 'kTextDisplayCrossover' [-Werror,-Wunused-const-variable]
[task 2023-08-31T23:27:56.131Z] 23:27:56     INFO -  const CGFloat kTextDisplayCrossover = 20.0;  // use text family below this size
[task 2023-08-31T23:27:56.131Z] 23:27:56     INFO -                ^
[task 2023-08-31T23:27:56.131Z] 23:27:56     INFO -  1 error generated.
[task 2023-08-31T23:27:56.132Z] 23:27:56    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:669: gfxMacPlatformFontList.o] Error 1
[task 2023-08-31T23:27:56.132Z] 23:27:56     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/gfx/thebes'
[task 2023-08-31T23:27:56.133Z] 23:27:56     INFO -  gmake[4]: Target 'target-objects' not remade because of errors.

Comment 1

[Natalia Csoregi [:nataliaCs]]

Hi, Jonathan, this seems to be caused by Bug 1170986.
Can you take a look, please?
Thank you.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1170986

Comment 3

[Jonathan Kew [:jfkthame]]

This has moved to CoreTextFontList.cpp, but accidentally got left here as well; we can just remove it.

(Bug 1850883 will eliminate it altogether, but I'll just do the trivial thing here and leave the more extensive cleanup for that bug.)

Comment 4

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1851071 - Remove stray unused variable. r=#gfx-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51bf4bb98f73
Remove stray unused variable. r=gfx-reviewers,jrmuizel

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/51bf4bb98f73

Comment 7

[Intermittent Failures Robot]

9 failures in 3019 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 9

Platform and build breakdown:

• osx-cross: 9
  • plain: 9

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1851071&startday=2023-08-28&endday=2023-09-03&tree=all