1851107 - rlboxed soundtouch code is in libxul

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Mike Hommey [:glandium]]

I should have caught this during review in bug 1673285, but we got ourselves a big problem with soundtouch: it's LGPL. And as such we need to keep it separate from libxul. Unfortunately, that's not something that rlbox supports right now...

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1851107 - Disable wasm sandboxing of libsoundtouch.

Until we figure out how to make it happen in a LGPL-abiding way.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1673285

Comment 3

[Shravan Narayan]

Would the solution here be : have libsoundtouch dynamically linked (which RLBox should support fine), and would only require adjusting the moz.build settings? Or would libsoundtouch have to be dynamically loaded as well? If it needs to be dynamically loaded, I can build an RLBox wasm2c plugin which uses dlopen/dlsym pretty easily (in fact we were doing this earlier when we relied on lucet)

Comment 4

[Mike Hommey [:glandium]]

Would the solution here be : have libsoundtouch dynamically linked (which RLBox should support fine), and would only require adjusting the moz.build settings?

At a very high level, yes. There are a bunch of subtle things that go wrong, though (like the circular dependency between libxul and liblgpglibs because of CrashReporter::AnnotateCrashReport in rlbox_wasm2c_thread_locals.cpp).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/763648bda75d
Disable wasm sandboxing of libsoundtouch. r=media-playback-reviewers,karlt

Comment 6

[Cristina Horotan [:chorotan]]

Backed out changeset 763648bda75d (bug 1851107) for causing creashtest failures at rlbox_noop_sandbox.hpp

Backout: https://hg.mozilla.org/integration/autoland/rev/41426b5e88f0a0d884470ee3278183ad90da44b2

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=763648bda75d5217fd784eac049db6cf5f19d561

Failure log: https://treeherder.mozilla.org/logviewer?job_id=427977770&repo=autoland&lineNumber=6842

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c870f975ac3d
Disable wasm sandboxing of libsoundtouch. r=media-playback-reviewers,karlt

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/c870f975ac3d

Comment 9

[Donal Meehan [:dmeehan]]

:glandium any follow-up expected on this?
Wondering if it should it still be leave-open?

Comment 10

[Mike Hommey [:glandium]]

I was hoping what landed would be backed out by the time the freeze starts, but this is probably not going to happen, so let's keep things simple as far as release tracking is, and close this bug, since the issue as filed is fixed. I'll file a followup for what's remaining.