1851110 - The keyboard-selected option for the address bar is not visible with dark default theme

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: system_theme.gif

Found in

• 119.0a1 (2023-08-31)

Affected versions

• 119.0a1 (2023-08-31)

Tested platforms

• Affected platforms: macOS 12, Windows 10x64
• Unaffected platforms: Ubuntu 22.1

Preconditions

• system theme set to dark
• Firefox set to system theme

Steps to reproduce

1. Open Firefox type something in the URL bar.
2. Use the keyboard key to navigate the options.

Expected result

• The selected option is visible.

Actual result

• The selected option is not visible.

Regression range

• Last good revision: f95c18989fd2d01b7228b5205f6851ec48fe7d42
  First bad revision: 37a26c9f2c5ced491362e75d2133695fb55d862d
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f95c18989fd2d01b7228b5205f6851ec48fe7d42&tochange=37a26c9f2c5ced491362e75d2133695fb55d862d

Additional notes

• Attached a screen recording.
• The mouse hover effect is visible.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1843044, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1851110 - Override toolbar-field-focus styles in browser-custom-colors. r=dao

This used to be achieved via the dark theme, but I overlooked that there
was no browser-custom-colors equivalent.

On the light theme we were relying on Field / FieldText being black /
white, so make that explicit too:

InspectorUtils.colorToRGBA("Field", document) // Object { a: 1, b: 255, g: 255, r: 255 }
InspectorUtils.colorToRGBA("FieldText", document) // Object { a: 1, b: 0, g: 0, r: 0 }.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Fixed by backout, will re-land with this fixed.

Comment 4

[Giorgia Nichita, Release Desktop QA]

Reproduced this on Win 10 and macOS 11 on a nightly build from 2023-08-31.
Verified as fixed on Firefox 119.0b4 (20231002091755) on the above mentioned OSes.