1851128 - There is low contrast on Save button on the Add/Edit Bookmark panel, especially on hover

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Found in

• 119.0a1 (2023-08-31)

Affected versions

• 119.0a1 (2023-08-31)

Tested platforms

• Affected platforms: Windows 10x64, macOS 13
• Unaffected platforms: Ubuntu 22.1

Preconditions

• System theme set to dark
• Firefox set to system theme

Steps to reproduce

1. Open a random webpage and bookmark it.
2. Observe the bookmark menu.
3. Hove over the Save button.

Expected result

• The Save button is readable.

Actual result

• The Save button is hard to read.

Regression range

• Last good revision: f95c18989fd2d01b7228b5205f6851ec48fe7d42
  First bad revision: 37a26c9f2c5ced491362e75d2133695fb55d862d
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f95c18989fd2d01b7228b5205f6851ec48fe7d42&tochange=37a26c9f2c5ced491362e75d2133695fb55d862d

Additional notes

• Attached a screen recording.

Comment 1

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: contrast_bookmarks_panel.gif

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1843044, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Fixed by backout. Will reland with this addressed.

Comment 4

[Giorgia Nichita, Release Desktop QA]

Reproduced this on Windows 10 and macOS 11 on a affected Nightly build from 2023-09-01.
Verified as fixed on Firefox 119.0b4 (20231002091755) on the above mentioned OSes.