1851154 - Provide our own implementation of C's getline on Android

Status: RESOLVED FIXED

(Core :: mozglue, task)

Description

[[:sergesanspaille]]

+++ This bug was initially created as a clone of Bug #914190 +++

We can't use getline() from Gecko on Android Jelly Bean because it calls bionic's realloc (not overrideable, despite having default visbility), and the caller needs to free() the result, and that will use jemalloc's free().

So, write a getline(), or import someone else's, and add it to libmozglue.

Comment 1

[[:sergesanspaille]]

Attachment: Bug 1851154 - Provide our own implementation of C's getline for Android r=jld!

10 years ago (!) Bug 914190 already choked on the fact that bionic's
getline implementation could realloc a buffer using a function call
we cannot intercept, resulting in different memory allocator being used
to allocate and free the getline buffer.

This got hit again by 1850948, causing a backout. The approach taken at
that time (use std::getline) is neither future-proof (as demonstrated by
the backout) nor always satisfying (std::string as a few limitations in
term of low-level buffer manipulation).

Provide our implementation for Android, as hinted by the original bug.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7cf8ad6c6cb0
Provide our own implementation of C's getline for Android r=jld

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7cf8ad6c6cb0