1851250 - MathML layout not updated correctly if textnode's data is updated

Status: RESOLVED FIXED

(Core :: MathML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: mathml.diff

The patch is for testing/web-platform/tests/mathml/presentation-markup/tokens/dynamic-mtext-like-001.html to show how it breaks if one doesn't replace a text node but only modifies it.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

https://searchfox.org/mozilla-central/rev/8fadd32a97de2efdbbfb067bb59d0017b00fb8bb/layout/mathml/nsMathMLTokenFrame.cpp#74-83 looks suspicious

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Hmm, this isn't as trivial as I had hoped.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1851250, test, r=emilio

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1851250, recreate the frame if single char math:mi changes, r=emilio

Depends on D187334

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7317614872da
test, r=emilio
https://hg.mozilla.org/integration/autoland/rev/39747a728e31
recreate the frame if single char math:mi changes, r=emilio

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41786 for changes under testing/web-platform/tests

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7317614872da
https://hg.mozilla.org/mozilla-central/rev/39747a728e31

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot