Closed Bug 1851260 Opened 3 years ago Closed 3 years ago

Update opus to new version 101a71e03bbf860aaafb7090a0e440675cb27660 from 2023-08-11 04:06:52

Categories

(Core :: Audio/Video: Playback, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
120 Branch
Tracking Status
firefox119 --- wontfix
firefox120 --- fixed

People

(Reporter: update-bot, Assigned: update-bot)

Details

(Whiteboard: [3pl-filed][task_id: AnaV3S8bRq61EU4FlJRmUA])

Attachments

(1 external file)

This update covers 2 commits, including 1 new upstream commit I've never filed a bug on before. (It's the top one.). Here are the overall diff statistics, and then the commit information.


media/libopus/celt/bands.c | 2 +-
media/libopus/moz.build | 2 +-
media/libopus/moz.yaml | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)


101a71e03bbf860aaafb7090a0e440675cb27660 by Jean-Marc Valin

https://gitlab.xiph.org/xiph/opus/commit/101a71e03bbf860aaafb7090a0e440675cb27660
Authored: 2023-08-11 04:06:52 -0400
Committed: 2023-08-11 04:06:52 -0400

Fixes stack overflow for some custom modes

This only affects custom modes (builds with --enable-custom-modes) with frame
sizes 2.5, 5, 10, and 20ms and sampling rates below 40 kHz. The problem does
not affect normal use of Opus (using OpusEncoder/OpusDecoder) even when built
with custom modes enabled, but only special applications that use
OpusCustomEncoder/OpusCustomDecoder.

Files Modified:

  • celt/bands.c

9fc8fc4cf432640f284113ba502ee027268b0d9f by Marcus Asteborg

https://gitlab.xiph.org/xiph/opus/commit/9fc8fc4cf432640f284113ba502ee027268b0d9f
Authored: 2023-06-13 22:22:58 -0700
Committed: 2023-06-14 01:46:52 -0400

Fix Gitlab CI

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Files Modified:

  • .gitlab-ci.yml

All the jobs in the try run succeeded. Like literally all of them, there weren't
even any intermittents. That is pretty surprising to me, so maybe you should double
check to make sure I didn't misinterpret things and that the correct tests ran...

Anyway, I've done all I can, so I'm passing to you to review and land the patch.
When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Assignee: nobody → kinetik
Assignee: kinetik → nobody
Assignee: nobody → update-bot
Status: NEW → ASSIGNED
Pushed by mgregan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e12bd9f0ee96 Update opus to 101a71e03bbf860aaafb7090a0e440675cb27660 r=kinetik
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
Flags: sec-bounty?
Flags: needinfo?(jmathies)
Flags: in-testsuite-
Flags: in-qa-testsuite-
Flags: behind-pref-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: