1851263 - Remove a few QueryInterface calls from dom/events/Event.cpp

Status: RESOLVED FIXED

(Core :: DOM: Events, task)

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1851263 - Remove a few QueryInterface calls from dom/events/Event.cpp. r=smaug

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1851263 - Rename nsIGlobalObject::AsInnerWindow to GetAsInnerWindow because it can return null. r=smaug

This is also the name that was originally suggested in https://bugzilla.mozilla.org/show_bug.cgi?id=218415#c53 .

Depends on D187339

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1851263 - Rename EventTarget::GetAsWindowInner to EventTarget::GetAsInnerWindow for consistency with nsIGlobal::GetAsInnerWindow. r=smaug

Also do the same for the "outer" variants.

Depends on D187340

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c17c38cd80cb
Remove a few QueryInterface calls from dom/events/Event.cpp. r=smaug
https://hg.mozilla.org/integration/autoland/rev/6462df7bf918
Rename nsIGlobalObject::AsInnerWindow to GetAsInnerWindow because it can return null. r=smaug
https://hg.mozilla.org/integration/autoland/rev/cb5384d5f69b
Rename EventTarget::GetAsWindowInner to EventTarget::GetAsInnerWindow for consistency with nsIGlobal::GetAsInnerWindow. r=smaug

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c17c38cd80cb
https://hg.mozilla.org/mozilla-central/rev/6462df7bf918
https://hg.mozilla.org/mozilla-central/rev/cb5384d5f69b