1851271 - Ensure the omnijar is shut down in the fork server to prevent memory leaks

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

I just tried pushing to Try with the fork server enabled, and there are a lot of errors like this:

TEST-UNEXPECTED-FAIL | leakcheck | forkserver 5168 bytes leaked (Mutex, nsLocalFile, nsStringBuffer, nsZipArchive, nsZipHandle)

I haven't investigated yet but I'm pretty sure this is from the Omnijar preloading in bug 1840515 — the fork server calls Omnijar::Init, and its child processes might call Omnijar::CleanUp but the fork server itself never does (I'm pretty sure). This is probably a one-line fix.

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1840515

Comment 2

[Pascal Chevrel (relman team) -> :pascalc]

Is that something we should fix for 118 or should it ride the trains?

Comment 3

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

(In reply to Pascal Chevrel:pascalc (PTO until August 21) from comment #2)

Is that something we should fix for 118 or should it ride the trains?

This is about code that's preffed off (and has other known issues), so it won't need uplift.

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Bug 1851271 - Avoid leaking the omnijar in the fork server.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8189cb3ba1a
Avoid leaking the omnijar in the fork server. r=nika

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d8189cb3ba1a