1851352 - Missing dependencies: Email::Address

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Dave Miller [:justdave]]

After checksetup.pl said all dependencies were resolved, my fresh install on a fresh server of Bugzilla 5.2 crashed complaining that it couldn't find Email::Address.

I then tried to run the tests, and the tests died complaining that it couldn't find POD::Coverage.

This was on an Ubuntu 22.04 server with most of the Perl modules installed via apt (and the few that apt couldn't find installed by install-module.pl --all.

Some diving with git blame shows that Email::Address has been a core dependency since version 3.3.2, and POD::Coverage has been an optional dependency for running tests since 4.5.1.

My best guess is that something else that we require used to pull these as dependencies and no longer does. But since they're not getting pulled automatically anymore, we need to have checksetup.pl looking for them.

Affected branches:

• Email::Address: 4.4, 5.0.4, 5.2, master(5.1) (harmony already checks for it)
• POD::Coverage: 5.0.4, 5.2 (none of 4.4, harmony, or master has this test)

Comment 1

[Frédéric Buclin]

(In reply to Dave Miller [:justdave] from comment #0)

After checksetup.pl said all dependencies were resolved, my fresh install on a fresh server of Bugzilla 5.2 crashed complaining that it couldn't find Email::Address.

My best guess is that something else that we require used to pull these as dependencies and no longer does. But since they're not getting pulled automatically anymore, we need to have checksetup.pl looking for them.

It looks like you have the latest version of Email::Sender (2.600). Per https://metacpan.org/dist/Email-Sender/changes, Email::Sender 2.600 now uses Email::Address::XS instead of Email::Address, which has some security flaws in versions 1.909 and older, see https://metacpan.org/pod/Email::Address#DESCRIPTION and https://metacpan.org/pod/Email::Address::XS#DESCRIPTION.

Note that both modules recommend to use Email::Address::XS instead of Email::Address. I then suggest that Bugzilla 5.2 and newer also do this move. There are very few places to fix and per https://metacpan.org/pod/Email::Address::XS#DESCRIPTION :

"Existing applications that use Email::Address module could be easily switched to Email::Address::XS module. In most cases only changing use Email::Address to use Email::Address::XS and replacing every Email::Address occurrence with Email::Address::XS is sufficient."

For Bugzilla 5.0.4 and 4.4, you would have to check if Email::Address is installed as moving to Email::Address::XS would not be acceptable on stable branches. But do you want to blacklist all versions older than 1.910 (release date: 2018-12-17)?

About POD::Coverage, there is already bug 929579 opened for that, which affects 5.0 and newer only, see bug 784072. Maybe rename your bug to focus on Email::Address only, and use bug 929579 to check POD::Coverage.

Comment 2

[Dave Miller [:justdave]]

(In reply to Frédéric Buclin from comment #1)

About POD::Coverage, there is already bug 929579 opened for that, which affects 5.0 and newer only, see bug 784072. Maybe rename your bug to focus on Email::Address only, and use bug 929579 to check POD::Coverage.

I'll go with this.
Bug 1853137 filed to deal with the POD Coverage test being missing on Harmony.

We'll just deal with the Email::Address situation here.

Comment 3

[Dave Miller [:justdave]]

Bug 1853138 filed for 5.2 and Harmony to switch to Email::Address::XS
That leaves this bug dealing with the older branches looking for Email::Address

Comment 4

[BMO Github Automation]

Attachment: [bugzilla/bugzilla] [4.4] Bug 1851352: Email::Address dependency missing (#173)

Comment 5

[BMO Github Automation]

Attachment: [bugzilla/bugzilla] [5.0.4] Bug 1851352: Email::Address dependency missing (#174)

Comment 6

[BMO Github Automation]

Attachment: [bugzilla/bugzilla] [5.3] Bug 1851352: Missing Email::Address dependency (#175)

Comment 7

[Dave Miller [:justdave]]

Comment on attachment 9401271 [details] [review]
[bugzilla/bugzilla] [4.4] Bug 1851352: Email::Address dependency missing (#173)

https://github.com/bugzilla/bugzilla/commit/56d255be5ac07b9ad8c37691e4052a63b081de51

Comment 8

[Dave Miller [:justdave]]

Comment on attachment 9401272 [details] [review]
[bugzilla/bugzilla] [5.0.4] Bug 1851352: Email::Address dependency missing (#174)

https://github.com/bugzilla/bugzilla/commit/7fa34b5a4c30632c406e869921bc187e31944e94

Comment 9

[Dave Miller [:justdave]]

Comment on attachment 9401275 [details] [review]
[bugzilla/bugzilla] [5.3] Bug 1851352: Missing Email::Address dependency (#175)

https://github.com/bugzilla/bugzilla/commit/2d066c09d0211ae7c84056f17bc6af64784e9a7b