185136 - Add menupopup 'id' for Edit Menu menupopup

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, enhancement)

Description

[Stephen Bounds]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2.1) Gecko/20021130
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2.1) Gecko/20021130

I develop a Mozilla add-on called Preferential (http://preferential.mozdev.org),
which currently appends a menu item to the bottom of the Navigator 'Edit' menu.
 I can do this because the XUL for the navigator menu overlay includes an id for
the menupopup XUL element like this:

<menupopup id="menu_Edit_Popup">

Messenger does not include this (or a similar) id, making it impossible to
customize with an overlay.



Reproducible: Always

Steps to Reproduce:
1. View code in messenger.jar -> mailWindowOverlay.xul.
2. Settle for alternative overlay or hack *.xul directly



Expected Results:  
Needs modification of code @ line 1050:

    <menupopup onpopupshowing="InitEditMessagesMenu()">

to

    <menupopup id="menu_Edit_Popup" onpopupshowing="InitEditMessagesMenu()">

Comment 1

[Mike Cowperthwaite]

No longer at line 1050; for Moz 1.4RC2, it's line 1095.

Comment 2

[Mike Cowperthwaite]

Attachment: patch

Very straightforward, following reporter's request.

Comment 3

[Mike Cowperthwaite]

Attachment: patch diff -u against 1.7-0310

(Somehow got the wrong file on that last patch)

Comment 4

[Mike Cowperthwaite]

Comment on attachment 143713 [details] [diff] [review]
patch   diff -u   against 1.7-0310

Neil, if you like this, could you also sr and check in?  It's pretty trivial.

Comment 5

[[e-mail]]

Comment on attachment 143713 [details] [diff] [review]
patch   diff -u   against 1.7-0310

r=me, but you don't need the spaces around the = sign. You'll need sr from
bienvenu or mscott (or sspitzer, though it seems unlikely!)

Comment 6

[Mike Cowperthwaite]

Attachment: Same patch, without the spaces.

Comment 7

[Mike Cowperthwaite]

Comment on attachment 143748 [details] [diff] [review]
Same patch, without the spaces.

I'll give David a break on this bug.  (Neil gets the break on the next one.)

Comment 8

[Mike Cowperthwaite]

Comment on attachment 143748 [details] [diff] [review]
Same patch, without the spaces.

Requesting approval for this trivial patch.

Comment 9

[chris hofmann]

Comment on attachment 143748 [details] [diff] [review]
Same patch, without the spaces.

a=chofmann for 1.7b

Comment 10

[[e-mail]]

Fix checked in.