Add menupopup 'id' for Edit Menu menupopup

RESOLVED FIXED

Status

--
enhancement
RESOLVED FIXED
16 years ago
14 years ago

People

(Reporter: GuruJ, Assigned: sspitzer)

Tracking

Trunk
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

16 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2.1) Gecko/20021130
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2.1) Gecko/20021130

I develop a Mozilla add-on called Preferential (http://preferential.mozdev.org),
which currently appends a menu item to the bottom of the Navigator 'Edit' menu.
 I can do this because the XUL for the navigator menu overlay includes an id for
the menupopup XUL element like this:

<menupopup id="menu_Edit_Popup">

Messenger does not include this (or a similar) id, making it impossible to
customize with an overlay.



Reproducible: Always

Steps to Reproduce:
1. View code in messenger.jar -> mailWindowOverlay.xul.
2. Settle for alternative overlay or hack *.xul directly



Expected Results:  
Needs modification of code @ line 1050:

    <menupopup onpopupshowing="InitEditMessagesMenu()">

to

    <menupopup id="menu_Edit_Popup" onpopupshowing="InitEditMessagesMenu()">

Comment 1

16 years ago
No longer at line 1050; for Moz 1.4RC2, it's line 1095.
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 2

15 years ago
Created attachment 143712 [details] [diff] [review]
patch

Very straightforward, following reporter's request.

Comment 3

15 years ago
Created attachment 143713 [details] [diff] [review]
patch   diff -u   against 1.7-0310

(Somehow got the wrong file on that last patch)
Attachment #143712 - Attachment is obsolete: true

Comment 4

15 years ago
Comment on attachment 143713 [details] [diff] [review]
patch   diff -u   against 1.7-0310

Neil, if you like this, could you also sr and check in?  It's pretty trivial.
Attachment #143713 - Flags: review?(neil.parkwaycc.co.uk)

Comment 5

15 years ago
Comment on attachment 143713 [details] [diff] [review]
patch   diff -u   against 1.7-0310

r=me, but you don't need the spaces around the = sign. You'll need sr from
bienvenu or mscott (or sspitzer, though it seems unlikely!)
Attachment #143713 - Flags: review?(neil.parkwaycc.co.uk) → review+

Comment 6

15 years ago
Created attachment 143748 [details] [diff] [review]
Same patch, without the spaces.
Attachment #143713 - Attachment is obsolete: true

Comment 7

15 years ago
Comment on attachment 143748 [details] [diff] [review]
Same patch, without the spaces.

I'll give David a break on this bug.  (Neil gets the break on the next one.)
Attachment #143748 - Flags: superreview?(mscott)

Updated

15 years ago
Attachment #143748 - Flags: superreview?(mscott) → superreview+

Comment 8

15 years ago
Comment on attachment 143748 [details] [diff] [review]
Same patch, without the spaces.

Requesting approval for this trivial patch.
Attachment #143748 - Flags: approval1.7b?

Comment 9

15 years ago
Comment on attachment 143748 [details] [diff] [review]
Same patch, without the spaces.

a=chofmann for 1.7b
Attachment #143748 - Flags: approval1.7b? → approval1.7b+

Comment 10

15 years ago
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.