1851412 - Use of uninitialized value $dbd in concatenation (.) or string at t/001compile.t line 90.

Status: RESOLVED FIXED

(Bugzilla :: Testing Suite, defect)

Description

[Bugzilla Project Triage Bot]

bugzilla-5.2# perl runtests.pl
t/001compile.t ....... 87/232 Use of uninitialized value $dbd in concatenation (.) or string at t/001compile.t line 90.
Use of uninitialized value $dbd in concatenation (.) or string at t/001compile.t line 90.
t/001compile.t ....... ok

It doesn't fail the test, but it looks bad.

Comment 1

[Bugzilla Project Triage Bot]

with --verbose, I get this:

ok 112 - use Bugzilla::DB::Sqlite;
ok 113 - use Bugzilla::DB::Mysql;
Use of uninitialized value $dbd in concatenation (.) or string at t/001compile.t line 90.
Use of uninitialized value $dbd in concatenation (.) or string at t/001compile.t line 90.
ok 114 # skip Bugzilla/DB/QuoteIdentifier.pm:  not installed
ok 115 # skip Bugzilla/DB/Pg.pm: DBD::Pg not installed
ok 116 # skip Bugzilla/DB/Oracle.pm: DBD::Oracle not installed

Looks like the new Bugzilla/DB/QuoteIdentifier.pm is at fault, which makes this a regression from bug 1592129

Comment 2

[Bugzilla Project Triage Bot]

There's multiple commits on that bug, it's this one specifically:
https://github.com/bugzilla/bugzilla/commit/35210c061e2ef7831624eafbc69cdbae08dc3d57

Comment 3

[Dave Miller [:justdave]]

Oops, didn't realize I was in the container with the other account loaded, this was me filing this.

Comment 4

[Dave Miller [:justdave]]

Bugzilla/DB/QuoteIdentifier.pm is not a DB driver module, it's a DB utility module. The correct fix is probably to add it to the exclusion list for that specific test (just like Bugzilla/DB/Schema.pm already is).

Comment 5

[Dave Miller [:justdave]]

Attachment: GitHub Pull Request for 5.2

Comment 6

[Dave Miller [:justdave]]

https://github.com/bugzilla/bugzilla/commit/db172903e337d182f7d2672745a6378312176745