1851438 - Sync vendored puppeteer to v21.2.0

Status: RESOLVED FIXED

(Remote Protocol :: CDP, task, P2)

Description

[Julian Descottes [:jdescottes]]

Last sync was Bug 1842198, and a lot of new tests have been enabled for BiDi since then so it would be nice to do a sync and run those in our CI as well.

As of filing, the latest puppeteer is v21.1.1: https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-core-v21.1.1

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1851438 - [remote] Sync vendored puppeteer to v21.1.1

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1851438 - [remote] Fix expectations and tests for Puppeteer on mozilla CI

Depends on D187649

Comment 3

[Julian Descottes [:jdescottes]]

On our CI, some tests timing out pollute the next tests because of browsingContext events with a null context.
I imagine this only happens on our CI because it runs faster than the puppeteer one.

Therefore blocking on Bug 1847563.

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1851438 - [remote] Sync vendored puppeteer to v21.2.0

Depends on D188103

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1851438 - [remote] Fix expectations and tests for Puppeteer v21.2.0 on mozilla CI

Depends on D188104

Comment 6

[Julian Descottes [:jdescottes]]

Corresponding puppeteer PR: https://github.com/puppeteer/puppeteer/pull/10898

Comment 7

[Julian Descottes [:jdescottes]]

Summary of the diff in terms of passing tests:

• Before: "suites": 229, "tests": 1008, "passes": 391, "pending": 517, "failures": 100
• After: "suites": 242, "tests": 1031, "passes": 486, "pending": 431, "failures": 118
• Diff: +13 suites, +23 tests, +95 passes, -86 pending, +18 failures

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f478c25b8ec7
[remote] Sync vendored puppeteer to v21.2.0 r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/94f558270b29
[remote] Fix expectations and tests for Puppeteer v21.2.0 on mozilla CI r=webdriver-reviewers,whimboo

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f478c25b8ec7
https://hg.mozilla.org/mozilla-central/rev/94f558270b29