Closed Bug 1851449 Opened 3 months ago Closed 3 months ago

Trending checkbox is not greyed out when suggestions are turned off

Categories

(Firefox :: Address Bar, defect, P2)

Product:
Firefox
Component:
Address Bar
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
119 Branch
Tracking Flags:
Tracking Status
firefox118 --- fixed
firefox119 --- fixed

People

(Reporter: daleharvey, Assigned: daleharvey)

References

Details

(Whiteboard: [sng])

Attachments

(1 file)

Bug 1851449 - Ensure trending checkbox is disabled correctly. r=Gijs
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details | Review
No description provided.
Assignee: nobody → dharvey

Also, according to figma, the checkbox should also be greyed out when engine is not google.

Severity: -- → S4
Priority: -- → P2
Whiteboard: [sng]
Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cb1f05b1d8ef
Ensure trending checkbox is disabled correctly. r=Gijs,settings-reviewers

https://hg.mozilla.org/mozilla-central/rev/cb1f05b1d8ef

Status: NEW → RESOLVED
Closed: 3 months ago
status-firefox119: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch

Comment on attachment 9351641 [details]
Bug 1851449 - Ensure trending checkbox is disabled correctly. r=Gijs

Beta/Release Uplift Approval Request

  • User impact if declined: Preferences UX for users enrolled in trending experiment will contain bugs
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Automated tests included and feature is under QA approval
  • String changes made/needed: None
  • Is Android affected?: No
Attachment #9351641 - Flags: approval-mozilla-beta?

Comment on attachment 9351641 [details]
Bug 1851449 - Ensure trending checkbox is disabled correctly. r=Gijs

Approved for 118.0b7, thanks.

Attachment #9351641 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.