1851517 - PDF editor resets active field when switching windows

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[dominateeye]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0

Steps to reproduce:

I opened a PDF in Firefox, edited a large text box, switched to another Firefox window, and switched back to the PDF window.

Actual results:

The edit I had made to the large text box disappeared, reverting the text box to its state before I edited it.

Expected results:

The large text box should have preserved my edit and remained the active text box when I switched back to the PDF window.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::PDF Viewer' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Calixte Denizet (:calixte)]

:andrew.ferg219, can you share the pdf ?

Comment 3

[dominateeye]

(In reply to Calixte Denizet (:calixte) from comment #2)

:andrew.ferg219, can you share the pdf ?

Sorry, no. It's a sensitive document.

Comment 4

[Calixte Denizet (:calixte)]

STR:

• open a tab with whatever you want
• open https://github.com/mozilla/pdf.js/blob/f2a4f2adaffcd35033641e61624fe37bb4f07ed1/test/pdfs/evaljs.pdf in a new tab
• write "hello" in the first text area
• click on the second area
• click on the first area
• write " world"
• click on an other tab
• click on the pdf tab

The first text area must contain the string "Hello World".

It's a regression from bug 1807983 and especially from:
https://github.com/mozilla/pdf.js/pull/15822

The issue is due to:
https://github.com/mozilla/pdf.js/blob/f2a4f2adaffcd35033641e61624fe37bb4f07ed1/src/display/annotation_layer.js#L1352-L1354

because here the relatedTarget is null but when we come back to the page a focus event is triggered and the previous value is just restored.
In Acrobat, Focus or Blur events aren't triggered either when the focus is moved on a another window (or tab in our case).

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1807983

Comment 6

[BMO Github Automation]

Attachment: [mozilla/pdf.js] Only call the focus/blur callbacks when it's necessary (bug 1851517) (#16905)

Comment 7

[Jonas Jenwald [:Snuffleupagus]]

Does this possibly fix bug 1823262 as well?

Comment 8

[Calixte Denizet (:calixte)]

Yes it does, thank you.

Comment 10

[Anca Soncutean, Desktop QA]

Reproduced with Fx 119.0a1 (2023-09-04) on Windows 10.
Verified fixed with FX 120.0a1(2023-10-01) and Fx 119.0b3 on Windows 10, Ubuntu22 and macOS 13.