Closed Bug 1851522 Opened 9 months ago Closed 9 months ago

Stop passing useless data from the parser worker

Categories

(DevTools :: Debugger, task)

task

Tracking

(firefox119 fixed)

RESOLVED FIXED
119 Branch
Tracking Status
firefox119 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

As highlighted in bug 1843454 comment 1, the parser worker (generating symbols/ast data) is computing and passing useless data from the worker thread to the main thread.
This isn't the largest data, but could still save some cycles.

Clarify which attributes are used only within the worker
and shouldn't be passed to the main thread.
Also clarify what are the usages of each attribute so that we can
more easily transfer some on-demand.

callExpressions wasn't used anywhere.

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6ffcc520b69a
[devtools] Only pass symbols used by the main thread. r=devtools-reviewers,bomsy
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
Depends on: 1851566

Perf compare with DAMP tweaks from bug 1855910 in the base revision.

This "new" revision includes patch from bug 1851566:
https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=3a3db8bb61b781a9077d726b1b88bfcc358344b0&originalSignature=4763542&newSignature=4763542&framework=12&application=firefox&originalRevision=984ac89f05363b8ed13d58e85471d10193a61aea&page=1&showOnlyImportant=1&filter=debugger

20% improvement on custom.jsdebugger.open-large-minified-file.full-selection.
13% improvement on custom.jsdebugger.pretty-print.reload-and-pause

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: