1851529 - Set clang-format ColumnLimit consistently

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Mike Hommey [:glandium]]

For some reason, its value in the Google style we use is 80... except for Objective-C, where it's 100, which led to things like: https://hg.mozilla.org/mozilla-central/rev/31bf68247e6e https://hg.mozilla.org/mozilla-central/rev/64ceb33533a4.

There's probably a discussion to have about whether 80 is the right limit, but since it's what's used for everything except ObjC, let's roll with it.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1851529 - Set clang-format ColumnLimit consistently.

For some reason, its value in the Google style we use is 80... except
for Objective-C, where it's 100, which led to things like:
https://hg.mozilla.org/mozilla-central/rev/31bf68247e6e
https://hg.mozilla.org/mozilla-central/rev/64ceb33533a4.

There's probably a discussion to have about whether 80 is the right
limit, but since it's what's used for everything except ObjC, let's roll
with it.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f62cec7eda6
Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/1f62cec7eda6

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1851529 - Fixup comments in hal/cocoa/smslib.mm

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27e5b3ede6ea
Fixup comments in hal/cocoa/smslib.mm r=andi

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/27e5b3ede6ea