185163 - Images which receive focus are only partly scrolled into view

Status: RESOLVED DUPLICATE of bug 66619

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Martin Wulffeld]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021130
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3a) Gecko/20021211

If I tab through a document with images the images aren't completely scrolled
into view if they were hidden - only a part of the top of an image is scrolled
into view. The height of this part corresponds with the current font size used
around the image so I suspect the wrong frame is being ScrolledIntoView(). In
other words if I zoom in a larger part of the image will be scrolled into view.

Reproducible: Always

Steps to Reproduce:
1. Go to Google images and search for 'Santa'.
2. Tab through the document till the page starts to scroll.
3. Scroll the page back up with the scrollbar. (Focus should remain on an image
which is now hidden).
4. Hit tab again to move focus to the next image.

Actual Results:  
Only a part of the image was scrolled into view.

Expected Results:  
Scroll as much of the image into view.

Comment 1

[Jesse Ruderman]

I think this is a dup of bug 66619.

Comment 2

[Martin Wulffeld]

Attachment: Patch #1

Jesse, I agree this is the same problem as 66619 however I believe from
investigating 66619 that the implementation fix might be different as can be
seen from this patch. Pure speculation from my side though as I'm still
learning the src.

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

This seems like the wrong approach.  You need to look at the subtree in the case
where NS_FRAME_HAS_OUTSIDE_CHILDREN is set, and probably (for the other bug)
consider next-in-flows (perhaps optionally, since some callers may not want them).

Comment 4

[Martin Wulffeld]

Taking btw.

David, I completely agree and I'm working on it. Didn't know of
NS_FRAME_OUTSIDE_CHILDREN until you mentioned it. Hence, I will drop using the
FrameTraversal stuff and simply use frame->FirstChild() and
frame->GetNextSibling() to cover the subtree. That should do it, right? It seems to.

Regarding bug #66619 the patch I attached there uses GetNextInFlow().

Comment 5

[Martin Wulffeld]

Dup of #66619. Work to get this case fixed will happen in #66619.

*** This bug has been marked as a duplicate of 66619 ***