1851676 - Add ability to initialize sentry on startup

Status: RESOLVED FIXED

(Firefox for Android :: Crash Reporting, task, P1)

Description

[Jeff Boek [:boek]]

Currently we're initializing Sentry before we send a crash report. This is causing sentry to think that every session is a crashed session which is causing issues with reporting. We want to be able to initialize on start so that Sentry will be able to send their session start ping to accurately measure crash free sessions.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1851676 - Adds ability to initialize Sentry on startup (#3502)

Comment 2

[Jonathan Almeida [:jonalmeida]]

For added background: we are seeing only Release show up with a spike of "crash free sessions", but this seems to be case because we only send fatal crashes to Sentry when the Sentry SDK is initialized which starts a session at that point. So therefore almost all sessions turn into crashed sessions because we don't initialize the SDK if nothing is wrong.

Comment 3

[Jonathan Almeida [:jonalmeida]]

Added bug 1835107 for traceability so we know what lead us down this path to decide to do this change.

Comment 4

[BMO Github Automation]

Authored by https://github.com/boek
https://github.com/mozilla-mobile/firefox-android/commit/16a37cf474e00f46281adeb06f81e1e0f5f6cd4e
[main] Bug 1851676 - Makes initIfNeeded public inside SentryService.

Comment 5

[Adina Petridean QA [:apetridean]]

Hello Jeff,

Is QA verification needed for this issue? If so, could you please provide us with some steps to reproduce (STR) or testing scenarios?

Thank you!

Comment 6

[Jeff Boek [:boek]]

Hey Adina,

No QA verification needed. We will monitor Sentry for success

Comment 7

[Chris Peterson [:cpeterson]]

Jeff, should we uplift this Sentry fix to next week's 118 dot release?

Comment 8

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1851676 - Adds ability to initialize Sentry on startup (backport #3502) (#3914)

Comment 9

[Jeff Boek [:boek]]

Comment on attachment 9356421 [details] [review]
[mozilla-mobile/firefox-android] Bug 1851676 - Adds ability to initialize Sentry on startup (backport #3502) (#3914)

Beta/Release Uplift Approval Request

• User impact if declined: Sentry will continue to report every session as a crashed session for release.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We delay the initialization of Sentry till after first paint. Patch has lived in Nightly and Beta for a couple of weeks.
• String changes made/needed:
• Is Android affected?: Yes

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9356421 [details] [review]
[mozilla-mobile/firefox-android] Bug 1851676 - Adds ability to initialize Sentry on startup (backport #3502) (#3914)

Approved for our next 118 dot release, thanks.

Comment 11

[BMO Github Automation]

Authored by https://github.com/boek
https://github.com/mozilla-mobile/firefox-android/commit/92a5d8c749fc3f8f32e64b4b369e46936567bfbc
[releases_v118] Bug 1851676 - Makes initIfNeeded public inside SentryService.