1851732 - Update gtest to at least commit be03d00

Status: RESOLVED FIXED

(Testing :: GTest, task, P3)

Description

[June Wilde (she/her) [:jewilde]]

Compiling the vendored version of gtest with C++20 fails with no member named 'u8string' in namespace 'std' for gtest-printers.h.

This was fixed in Issue 3659 so vendoring be03d00f5f0cc3a997d1a368bee8a1fe93651f48 or newer (like tag 1.14.0) should fix this

Setting a maintainer in gtest's moz.yaml and enabling it in updatebot might be worthwhile as well

Comment 1

[Chris Peterson [:cpeterson]]

libvpx and nss have their own copies of gtest in tree:

https://searchfox.org/mozilla-central/source/media/libvpx/libvpx/third_party/googletest
https://searchfox.org/mozilla-central/source/security/nss/gtests/google_test

Comment 2

[Chris Peterson [:cpeterson]]

I'll land this after the Nightly 120 cycle starts.

Green gtests on Try:

https://treeherder.mozilla.org/jobs?repo=try&revision=eb9177afba77047657b2cb1649991e381030fffb

Comment 3

[Chris Peterson [:cpeterson]]

Attachment: Bug 1851732 - Vendor gtest e009c3d3dcb522c21ea83984dac6064a6399d3f6. r?ahal

Comment 4

[Chris Peterson [:cpeterson]]

Attachment: Bug 1851732 - Remove unnecessary gtest operator_comma_warning.patch. r?ahal

This patch is no longer needed because the comma warning was fixed in upstream gtest:

https://github.com/google/googletest/commit/3fa7f983c69f780378b4d1ad44d36030ca951ba6

Depends on D189067

Comment 5

[Chris Peterson [:cpeterson]]

Attachment: Bug 1851732 - Apply gtest patches. r?ahal

Depends on D189068

Comment 6

[Chris Peterson [:cpeterson]]

Attachment: Bug 1851732 - Check for gtest updates at the start of each Nightly release cycle. r?ahal

Depends on D189069

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6671631677e0
Vendor gtest e009c3d3dcb522c21ea83984dac6064a6399d3f6. r=ahal
https://hg.mozilla.org/integration/autoland/rev/8b6722985890
Remove unnecessary gtest operator_comma_warning.patch. r=ahal
https://hg.mozilla.org/integration/autoland/rev/a5aa4af93b13
Apply gtest patches. r=ahal

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6671631677e0
https://hg.mozilla.org/mozilla-central/rev/8b6722985890
https://hg.mozilla.org/mozilla-central/rev/a5aa4af93b13

Comment 9

[Chris Peterson [:cpeterson]]

Attachment: Bug 1851732 - Schedule updatebot to update gtest at the start of each Nightly release cycle. r?ahal

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7b43c5005ce
Schedule updatebot to update gtest at the start of each Nightly release cycle. r=ahal

Comment 11

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/a7b43c5005ce