1851759 - top-level await does not handle for..in

Status: VERIFIED FIXED

(DevTools :: Console, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe][PTO - back on Monday May 13th]]

Steps to reproduce

1. Open the console
2. Evaluate the following

j = { "foo": 1, "bar": 2}
await 42
for (var k in j){
  console.log(k)
}

Expected results

foo and bar are logged to the console output

Actual results

only undefined is logged

---

It looks like something is wrong in the transformation we do to the input.
Here's the actual expression we send to the server:

(async () => {
  j = {
    "foo": 1,
    "bar": 2
  };
  await 42;
  return;
})();

the mapping is done in https://searchfox.org/mozilla-central/rev/a4cb813cd4026cc24b45e843222e6a08204bae47/devtools/client/debugger/src/workers/parser/mapAwaitExpression.js

Bug 1839588 would help here, but this can probably be fixed in DevTools codebase.

Comment 1

[Krishna Ravishankar]

Attachment: Bug 1851759 - [devtools] Fix incorrect removal of non-expr-stmt when top-level-await is present r=#devtools-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00a66a4ea7d3
[devtools] Fix incorrect removal of non-expr-stmt when top-level-await is present r=devtools-reviewers,nchevobbe

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/00a66a4ea7d3

Comment 4

[Ardelean Oana, Desktop QA [:oardelean]]

Reproducible on a 2023-09-05 Nightly build on macOS 12.
Verified as fixed on Firefox 119.0b4(build ID: 20231002091755) and Nightly 120.0a1(build ID: 20231002221644) on macOS 12, Windows 10, Ubuntu 22.