Closed
Bug 1851794
Opened 8 months ago
Closed 8 months ago
Change debugger ESLint rules that are warnings to errors, and turn off react/prop-types.
Categories
(DevTools :: Debugger, task)
DevTools
Debugger
Tracking
(firefox119 fixed)
RESOLVED
FIXED
119 Branch
Tracking | Status | |
---|---|---|
firefox119 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
I'm looking to reduce the cases where we have long term ESLint rules reporting as warnings. If we have reason to be raising an issue, then we should ensure it is addressed, rather than letting it languish in amongst other warnings where it can become ambiguous as to why it hasn't been addressed.
In debugger there are a number of rules that are currently marked as warnings, even though they don't have any issues raised currently. We should transition those to errors.
For the react/prop-types
rule, there are issues raised, but the plan in bug 1841645 is to remove propTypes definitions from the debugger code base, hence it will no longer be needed so it can be turned off here.
Assignee | ||
Comment 1•8 months ago
|
||
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/19d1224f216a Change debugger ESLint rules that are warnings to errors, and turn off react/prop-types. r=devtools-reviewers,ochameau
Comment 3•8 months ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 months ago
status-firefox119:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•