1851824 - Expand test coverage of invalid URLs in tabs.create/update / windows.create

Status: NEW

(WebExtensions :: General, task, P3)

Description

[Rob Wu [:robwu]]

For completeness, we should verify that invalid URLs are consistently rejected across the extension APIs that open new tabs:

• tabs.create
  • https://searchfox.org/mozilla-central/rev/a4cb813cd4026cc24b45e843222e6a08204bae47/browser/components/extensions/test/browser/browser_ext_tabs_create_invalid_url.js#51-79
• tabs.update
  • (none, despite the message stating tabs.update in the tabs.create test linked above)
• windows.create
  • https://searchfox.org/mozilla-central/rev/a4cb813cd4026cc24b45e843222e6a08204bae47/browser/components/extensions/test/browser/browser_ext_windows_create_url.js#128-143

It would also be nice to have tests like these in toolkit/, so that they can run on Android too. E.g. by creating a new test file that lists a bunch of invalid URLs and then calling tabs.create / tabs.update / windows.create (after doing feature detection to verify that these methods exist and/or adding conditions to skip unsupported APIs on specific platforms) and expecting a rejection. That could also be expanded to other extension APIs that accept URLs.

Comment 1

[Rob Wu [:robwu]]

The tabs.create API already has unit tests for file:-URLs, the windows.create API doesn't have tests either. We should ensure that all these APIs test file:-URLs (e.g. to verify the intended behavior that was questioned in bug 1864001).