1851832 - Assertion failure: mState != XMLHttpRequest_Binding::UNSENT, at /dom/xhr/XMLHttpRequestMainThread.cpp:1317

Status: VERIFIED FIXED

(Core :: DOM: Networking, defect, P2)

Description

[Jason Kratzer [:jkratzer]]

Testcase found while fuzzing mozilla-central rev 5c56b92baa65 (built with: --enable-debug --enable-fuzzing).

Testcase can be reproduced using the following commands:

$ pip install fuzzfetch grizzly-framework
$ python -m fuzzfetch --build 5c56b92baa65 --debug --fuzzing -n firefox
$ python -m grizzly.replay ./firefox/firefox testcase.html

Assertion failure: mState != XMLHttpRequest_Binding::UNSENT, at /dom/xhr/XMLHttpRequestMainThread.cpp:1317

    ==480476==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address 0x000000000000 (pc 0x7f6f2dd21a98 bp 0x7ffcc329cfe0 sp 0x7ffcc329cfc0 T480476)
    ==480476==The signal is caused by a WRITE memory access.
    ==480476==Hint: address points to the zero page.
        #0 0x7f6f2dd21a98 in mozilla::dom::XMLHttpRequestMainThread::FireReadystatechangeEvent() /dom/xhr/XMLHttpRequestMainThread.cpp:1317:3
        #1 0x7f6f2dd31af0 in mozilla::dom::XMLHttpRequestMainThread::HandleProgressTimerCallback() /dom/xhr/XMLHttpRequestMainThread.cpp:3712:5
        #2 0x7f6f2dd31a07 in mozilla::dom::XMLHttpRequestMainThread::Notify(nsITimer*) /dom/xhr/XMLHttpRequestMainThread.cpp:3674:5
        #3 0x7f6f289a1b6b in operator() /xpcom/threads/nsTimerImpl.cpp:676:44
        #4 0x7f6f289a1b6b in matchN<mozilla::Variant<nsTimerImpl::UnknownCallback, nsCOMPtr<nsITimerCallback>, nsCOMPtr<nsIObserver>, nsTimerImpl::FuncCallback, nsTimerImpl::ClosureCallback> &, (lambda at /xpcom/threads/nsTimerImpl.cpp:676:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:677:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:680:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:681:7)> /builds/worker/workspace/obj-build/dist/include/mozilla/Variant.h:309:16
        #5 0x7f6f289a1b6b in matchN<mozilla::Variant<nsTimerImpl::UnknownCallback, nsCOMPtr<nsITimerCallback>, nsCOMPtr<nsIObserver>, nsTimerImpl::FuncCallback, nsTimerImpl::ClosureCallback> &, (lambda at /xpcom/threads/nsTimerImpl.cpp:675:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:676:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:677:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:680:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:681:7)> /builds/worker/workspace/obj-build/dist/include/mozilla/Variant.h:318:14
        #6 0x7f6f289a1b6b in matchN<mozilla::Variant<nsTimerImpl::UnknownCallback, nsCOMPtr<nsITimerCallback>, nsCOMPtr<nsIObserver>, nsTimerImpl::FuncCallback, nsTimerImpl::ClosureCallback> &, (lambda at /xpcom/threads/nsTimerImpl.cpp:675:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:676:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:677:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:680:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:681:7)> /builds/worker/workspace/obj-build/dist/include/mozilla/Variant.h:902:12
        #7 0x7f6f289a1b6b in match<(lambda at /xpcom/threads/nsTimerImpl.cpp:675:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:676:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:677:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:680:7), (lambda at /xpcom/threads/nsTimerImpl.cpp:681:7)> /builds/worker/workspace/obj-build/dist/include/mozilla/Variant.h:857:12
        #8 0x7f6f289a1b6b in nsTimerImpl::Fire(int) /xpcom/threads/nsTimerImpl.cpp:674:22
        #9 0x7f6f289a0d1f in nsTimerEvent::Run() /xpcom/threads/TimerThread.cpp:474:11
        #10 0x7f6f28994697 in mozilla::RunnableTask::Run() /xpcom/threads/TaskController.cpp:559:16
        #11 0x7f6f2898c213 in mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /xpcom/threads/TaskController.cpp:886:26
        #12 0x7f6f2898aa67 in mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /xpcom/threads/TaskController.cpp:709:15
        #13 0x7f6f2898aec5 in mozilla::TaskController::ProcessPendingMTTask(bool) /xpcom/threads/TaskController.cpp:495:36
        #14 0x7f6f28998429 in operator() /xpcom/threads/TaskController.cpp:221:37
        #15 0x7f6f28998429 in mozilla::detail::RunnableFunction<mozilla::TaskController::TaskController()::$_1>::Run() /xpcom/threads/nsThreadUtils.h:548:5
        #16 0x7f6f289aebda in nsThread::ProcessNextEvent(bool, bool*) /xpcom/threads/nsThread.cpp:1199:16
        #17 0x7f6f289b5acd in NS_ProcessNextEvent(nsIThread*, bool) /xpcom/threads/nsThreadUtils.cpp:480:10
        #18 0x7f6f2966a7d3 in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) /ipc/glue/MessagePump.cpp:107:5
        #19 0x7f6f295857b1 in RunHandler /ipc/chromium/src/base/message_loop.cc:363:3
        #20 0x7f6f295857b1 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:345:3
        #21 0x7f6f2dff6cb8 in nsBaseAppShell::Run() /widget/nsBaseAppShell.cpp:148:27
        #22 0x7f6f3026375b in XRE_RunAppShell() /toolkit/xre/nsEmbedFunctions.cpp:722:20
        #23 0x7f6f2966b706 in mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) /ipc/glue/MessagePump.cpp:235:9
        #24 0x7f6f295857b1 in RunHandler /ipc/chromium/src/base/message_loop.cc:363:3
        #25 0x7f6f295857b1 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:345:3
        #26 0x7f6f30262f83 in XRE_InitChildProcess(int, char**, XREChildData const*) /toolkit/xre/nsEmbedFunctions.cpp:657:34
        #27 0x5576e697f926 in content_process_main /browser/app/../../ipc/contentproc/plugin-container.cpp:57:28
        #28 0x5576e697f926 in main /browser/app/nsBrowserApp.cpp:375:18
        #29 0x7f6f3cda3d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
        #30 0x7f6f3cda3e3f in __libc_start_main csu/../csu/libc-start.c:392:3
        #31 0x5576e6956bc8 in _start (/home/jkratzer/builds/m-c-20230906091315-fuzzing-debug/firefox-bin+0x58bc8) (BuildId: 32c29819e4a761a6cea3e4573a5d4564a3a8e25f)
    
    UndefinedBehaviorSanitizer can not provide additional info.
    SUMMARY: UndefinedBehaviorSanitizer: SEGV /dom/xhr/XMLHttpRequestMainThread.cpp:1317:3 in mozilla::dom::XMLHttpRequestMainThread::FireReadystatechangeEvent()
    ==480476==ABORTING

Comment 1

[Jason Kratzer [:jkratzer]]

Attachment: Testcase

Comment 2

[Jason Kratzer [:jkratzer]]

Attachment: testcase.html

Comment 3

[Bugmon [:jkratzer for issues]]

Verified bug as reproducible on mozilla-central 20230906091315-5c56b92baa65.
Unable to bisect testcase (Testcase reproduces on start build!):

Start: 47e03ec3e25b8c196bd5f5ff8e54802f947e99be (20220907035543)
End: 5c56b92baa65aa27df61f84718594767ef8f26f4 (20230906091315)
BuildFlags: BuildFlags(asan=None, tsan=None, debug=True, fuzzing=True, coverage=None, valgrind=None, no_opt=None, fuzzilli=None, nyx=None)

Comment 4

[Thomas Wisniewski [:twisniewski]]

:jkratzer, :kershaw, I don't see this test-case tripping that assertion on a local debug build. Maybe this has since been fixed?

Comment 5

[Jason Kratzer [:jkratzer]]

I can still reproduce this bug on mozilla-central revision fc0f7d3e6a3d (20240624).

Comment 6

[Valentin Gosu [:valentin] {{ PTO 3 July - 3 August }}]

Attachment: Bug 1851832 - Don't dispatch XHR progress events/state changes when the state is UNSENT r=#necko

Comment 7

[Tyson Smith [:tsmith]]

A Pernosco session is available here: https://pernos.co/debug/g-RVnXLCO30jaqZdb6rRHA/index.html

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/85347ab57833
https://hg.mozilla.org/integration/autoland/rev/72f076a130bb
Don't dispatch XHR progress events/state changes when the state is UNSENT r=necko-reviewers,jesup

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/58158 for changes under testing/web-platform/tests

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/72f076a130bb

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 12

[Bugmon [:jkratzer for issues]]

Verified bug as fixed on rev mozilla-central 20260302165305-5721f1ebc22f.
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.