1851833 - Use chrome font sizes instead of in-content sizes

Status: RESOLVED FIXED

(Firefox :: Shopping, defect, P2)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

This may be tricky because the sidebar with is a fixed number of pixels, but the chrome font size varies across platforms (11px on Mac, 12px on Windows, some huge number on Ubuntu).

As part of this discussion, we might want to switch the sidebar width to a value relative to the size of the font (subject to some max-width, presumably?).

Comment 1

[Anna Yeddi [:ayeddi]]

having larger font sizes would be preferable, but it won't be a major issue for accessibility either way. Following the system/chrome sizes is an appropriate approach a11y-wise.

Comment 2

[Julian Gaibler]

So I think the changes we talked about were the following:

• Changing the font sizes from in-content to chrome
• Either use font: menu or font: caption (no difference between those afaik)
• Making the sidebar width respond to the base font-size (320px at 13px base size is 24.6153846154em — round at your discretion haha)
• Header size does not need to be adjusted, since it's already relative :)

Smallest default font size would be Windows with 12px and the largest is Linux (Gnome) with 14.6667px, so it'd be good to check if everything looks okay with these two font sizes!

Comment 4

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1851833 - Use chrome font sizes for shopping sidebar. r=#shopping-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d244d17a8e9a
Use chrome font sizes for shopping sidebar. r=shopping-reviewers,desktop-theme-reviewers,kpatenio,dao

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d244d17a8e9a