Closed Bug 1851855 Opened 1 year ago Closed 1 year ago

Icons should use icon color

Categories

(Firefox :: Shopping, defect, P3)

Product:
Firefox
Component:
Shopping
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
120 Branch
Tracking Flags:
Tracking Status
firefox119 --- verified
firefox120 --- verified

People

(Reporter: jhirsch, Assigned: kpatenio)

References

Details

(Whiteboard: [fidefe-shopping])

Attachments

(2 files)

Icons in sidebar that should use the icon color
91.99 KB, image/jpeg
Details
Bug 1851855 - use --icon-color for shopping sidebar icons and icon buttons
48 bytes, text/x-phabricator-request
diannaS
: approval-mozilla-beta+
Details | Review
No description provided.
Priority: -- → P1

The right token is --icon-color.

I attached an image with all icons that should have this color applied :)

In the meeting I think the outcome was this was P3.

Severity: -- → S3
Priority: P1 → P3
Assignee: nobody → kpatenio
Whiteboard: [fidefe-shopping]
Pushed by kpatenio@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f96b24565d45 use --icon-color for shopping sidebar icons and icon buttons r=shopping-reviewers,niklas

Comment on attachment 9354665 [details]
Bug 1851855 - use --icon-color for shopping sidebar icons and icon buttons

Beta/Release Uplift Approval Request

  • User impact if declined: Minimal impact - icons will merely be a different color from our Figma spec, but shouldn't impact functionality for users overall.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Patch contains CSS changes for the color of shopping sidebar icons, in order to match our Figma spec and maintain consistency in styling. Does not affect user workflow.
  • String changes made/needed:
  • Is Android affected?: No
Attachment #9354665 - Flags: approval-mozilla-beta?

https://hg.mozilla.org/mozilla-central/rev/f96b24565d45

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox120: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch

Comment on attachment 9354665 [details]
Bug 1851855 - use --icon-color for shopping sidebar icons and icon buttons

Approved for 119.0b3

Attachment #9354665 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+

Verified fixed using Beta 119.0b3 (20230929091427) and Nightly 120.0a1 (20231001214422) on Windows 10, MacOS 11 and Ubuntu 20.04.

Status: RESOLVED → VERIFIED
status-firefox119: fixed → verified
status-firefox120: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: