1851878 - Turn off MR 2022 Upgrade Dialog

Status: VERIFIED FIXED

(Firefox :: Messaging System, task)

Description

[Punam Dahiya [:pdahiya]]

Scope of this bug is to turn off existing users MR onboarding dialog implemented with

https://bugzilla.mozilla.org/show_bug.cgi?id=1774071#c1

Comment 1

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: This is already remotely disabled with 100% rollout to 105+ on all channels, but telemetry shows that we're still getting a significant number of upgrade dialog/spotlight impressions. https://experimenter.services.mozilla.com/nimbus/upgrade-spotlight-rollout

The change should just be flipping this default pref value to false that QA effectively tested with the rollout disabling. https://searchfox.org/mozilla-central/rev/a4cb813cd4026cc24b45e843222e6a08204bae47/browser/app/profile/firefox.js#322

There's potential for uplift to release but waiting on product to decide if this should be nightly 119 or include beta 118 or include release 117.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

If we want to get this into next week's scheduled 117 dot release, I'll need a patch with approval request by EOD Friday. Thanks!

Comment 3

[Ed Lee :Mardak]

Attachment: Bug 1851878 - Turn off MR 2022 Upgrade Dialog r?pdahiya

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ae7a399eb72
Turn off MR 2022 Upgrade Dialog r=pdahiya

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/5ae7a399eb72

Comment 6

[Ed Lee :Mardak]

Comment on attachment 9351866 [details]
Bug 1851878 - Turn off MR 2022 Upgrade Dialog r?pdahiya

Beta/Release Uplift Approval Request

• User impact if declined: Users upgrading from older versions can see the upgrade spotlight if not enrolled into the 100% rollout.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. new profile in old firefox (this sets browser.startup.homepage_override.mstone to something like "100.0")

2. open profile in new firefox
3. don't see upgrade spotlight (about:telemetry events will include upgrade_dialog trigger reason disabled)

See more details in https://mozilla-hub.atlassian.net/browse/QA-2073

• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): QA already verified the rollout that effectively remotely sets the pref to false that this patch sets as default.
• String changes made/needed: none
• Is Android affected?: No

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9351866 [details]
Bug 1851878 - Turn off MR 2022 Upgrade Dialog r?pdahiya

Approved for 118.0b7, thanks.

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/04b94766f0dc

Comment 9

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/04b94766f0dc

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9351866 [details]
Bug 1851878 - Turn off MR 2022 Upgrade Dialog r?pdahiya

Approved for 117.0.1

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/1732193c104b

Comment 12

[Marius Coman [:mcoman], Ecosystem QA - PTO until 8th of November, for any requests ping :cmuresan]

I have verified this task using the steps provided in comment 6 and I can confirm the following:

• The Upgrade dialog is not triggered after a browser update even if the profile is not enrolled into the 100% rollout.
• The upgrade_dialog trigger reason disabled event is displayed on the "about:telemetry" page.

Verified using the latest Firefox Release (117.0.1 Build ID - 20230912013654), latest Firefox Beta (118.0 Build ID - 20230918143747), and Firefox Nightly (119.0a1 Build ID - 20230921091327) installed on Window 10 x64, macOS 13.5.1 and Linux Mint 21.1.