1851913 - Remove meow dependency since it's in project root

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P3)

Description

[Shane Hughes [:aminomancer]]

The project root now has meow, for stylelint (the same reason we initially installed it). It's using a newer version though, one that doesn't support CJS imports and requires import.meta to be passed. This requirement is only for it to get the importer's path though (actually, its file URL). So it can be tricked by just passing it { url: myFileUrl }.

So, there are 2 approaches. One is to update all our scripts that use meow to ESMs. The other is to update those scripts to dynamically import meow and pass it a fake importMeta. The more conservative approach is the latter, especially since try-runner.js is running on CI and turning it into an ESM requires changing its filename to try-runner.mjs.

Comment 1

[Shane Hughes [:aminomancer]]

Attachment: Bug 1851913 - Remove newtab's explicit meow dependency. r=#omc-reviewers,dmose

Since stylelint is now a dependency of the project root, and meow is
a dependency of stylelint, we don't need to explicitly list meow as a
dependency of newtab. The project root uses a newer version of meow that
requires some small workarounds to work outside of an ES module, so we
also need to update the newtab scripts that use meow.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4cd47b0cd52
Remove newtab's explicit meow dependency. r=omc-reviewers,negin

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out for causing meow related newtab failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=d4cd47b0cd52dc230b53bbdf8dc399a2d88e9f2f&selectedTaskRun=G5I2oqaaQcamTDe114pSLw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=430502149&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/a675b4047ca06f579250be186485fa49ab2cd16d

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6fc66d324cb8
Remove newtab's explicit meow dependency. r=omc-reviewers,negin

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6fc66d324cb8