[wpt-sync] Sync PR 41804 - [text-autospace] Fix when `LayoutNGShapeCache` is enabled
Categories
(Core :: Layout: Text and Fonts, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox119 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 41804 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/41804
Details from upstream follow.
Koji Ishii <kojii@chromium.org> wrote:
[text-autospace] Fix when
LayoutNGShapeCache
is enabledThis patch disables
LayoutNGShapeCache
iftext-autospace
may apply to theShapeResult
.Because
text-autospace
modifies theShapeResult
similar to
letter-/word-space
,LayoutNGShapeCache
should be disabled.To do this,
TextAutoSpace
is split into two parts; one to
initializeRunSegmenterRanges
and determine if it may apply,
and the later part that actually applies the spacing.Bug: 1463890
Change-Id: I4ba58a75c9e5ebcb564a8ab1f81eb989736a4eb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4834023
Auto-Submit: Koji Ishii \<kojii@chromium.org>
Commit-Queue: Lingqi Chi \<lingqi@chromium.org>
Reviewed-by: Lingqi Chi \<lingqi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1192233}
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Comment 2•2 years ago
|
||
CI Results
Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests
Status Summary
Firefox
FAIL
: 1
Chrome
FAIL
: 1
Safari
FAIL
: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /css/css-text/text-autospace/text-autospace-no-001.html [wpt.fyi]:
FAIL
(Chrome:FAIL
, Safari:FAIL
)
Comment 4•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cc9de8892752
https://hg.mozilla.org/mozilla-central/rev/22ccdc3634b0
Description
•