Closed Bug 1851977 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 41804 - [text-autospace] Fix when `LayoutNGShapeCache` is enabled

Categories

(Core :: Layout: Text and Fonts, task, P4)

task

Tracking

()

RESOLVED FIXED
119 Branch
Tracking Status
firefox119 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 41804 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41804
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

[text-autospace] Fix when LayoutNGShapeCache is enabled

This patch disables LayoutNGShapeCache if text-autospace
may apply to the ShapeResult.

Because text-autospace modifies the ShapeResult similar to
letter-/word-space, LayoutNGShapeCache should be disabled.

To do this, TextAutoSpace is split into two parts; one to
initialize RunSegmenterRanges and determine if it may apply,
and the later part that actually applies the spacing.

Bug: 1463890
Change-Id: I4ba58a75c9e5ebcb564a8ab1f81eb989736a4eb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4834023
Auto-Submit: Koji Ishii \<kojii@chromium.org>
Commit-Queue: Lingqi Chi \<lingqi@chromium.org>
Reviewed-by: Lingqi Chi \<lingqi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1192233}

Component: web-platform-tests → Layout: Text and Fonts
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cc9de8892752 [wpt PR 41804] - [text-autospace] Fix when `LayoutNGShapeCache` is enabled, a=testonly https://hg.mozilla.org/integration/autoland/rev/22ccdc3634b0 [wpt PR 41804] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
You need to log in before you can comment on or make changes to this bug.