1851977 - [wpt-sync] Sync PR 41804 - [text-autospace] Fix when `LayoutNGShapeCache` is enabled

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 41804 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41804
Details from upstream follow.

Koji Ishii <[e-mail]> wrote:

[text-autospace] Fix when LayoutNGShapeCache is enabled

This patch disables LayoutNGShapeCache if text-autospace
may apply to the ShapeResult.

Because text-autospace modifies the ShapeResult similar to
letter-/word-space, LayoutNGShapeCache should be disabled.

To do this, TextAutoSpace is split into two parts; one to
initialize RunSegmenterRanges and determine if it may apply,
and the later part that actually applies the spacing.

Bug: 1463890
Change-Id: I4ba58a75c9e5ebcb564a8ab1f81eb989736a4eb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4834023
Auto-Submit: Koji Ishii \<[e-mail]>
Commit-Queue: Lingqi Chi \<[e-mail]>
Reviewed-by: Lingqi Chi \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1192233}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0cc9d36c72729773bed27ea581dd91ebc08f4fba

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-text/text-autospace/text-autospace-no-001.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc9de8892752
[wpt PR 41804] - [text-autospace] Fix when `LayoutNGShapeCache` is enabled, a=testonly
https://hg.mozilla.org/integration/autoland/rev/22ccdc3634b0
[wpt PR 41804] - Update wpt metadata, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cc9de8892752
https://hg.mozilla.org/mozilla-central/rev/22ccdc3634b0