1852149 - Implement CSS margin-rule parsing and handling in Servo

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Comment 1

[Emily McDonough [:alaskanemily]]

Attachment: Bug 1852149 Part 2 - Refactor page-rule parsing and types to allow nested rules.

Comment 2

[Emily McDonough [:alaskanemily]]

Attachment: Bug 1852149 Part 1 - Add margin-rule pref

Comment 3

[Emily McDonough [:alaskanemily]]

Attachment: Bug 1852149 Part 3 - Add margin rules to servo

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Let's make sure that we have tests / bugs for:

• Kinds of nested rules allowed inside @page.
• Margin rules not being allowed outside @page (this should be easy to do now).
• Making CSSPageRule a CSSGroupingRule in the CSSOM.

It seems these patches should be testable (via CSSPageRule.cssText for (1) at least, via existing APIs for (2)).

Comment 5

[Emily McDonough [:alaskanemily]]

Tests added to part 2, point 3 is bug 1868215

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41983c01b704
Part 1 - Add margin-rule pref r=firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/f09d75c8d809
Part 2 - Refactor page-rule parsing and types to allow nested rules. r=firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/06cfcf08556f
Part 3 - Add margin rules to servo r=firefox-style-system-reviewers,emilio

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43585 for changes under testing/web-platform/tests

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/41983c01b704
https://hg.mozilla.org/mozilla-central/rev/f09d75c8d809
https://hg.mozilla.org/mozilla-central/rev/06cfcf08556f

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 11

[Sebastian Zartner [:sebo]]

This should be added to https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features, maybe with a note for the CSSMarginRule API once implemented in bug 1833466.

Sebastian