Closed Bug 1852179 Opened 2 years ago Closed 2 years ago

Bad implicit conversion constructor in pkixtestutil.h

Tracking

(Not tracked)

Status:

RESOLVED FIXED

People

(Reporter: jschanck, Assigned: jschanck)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Bug 1852179 - avoid implicit conversion for ByteString. r=#nss-reviewers 2 years ago John Schanck [:jschanck] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1852179 - declare string literals using char in pkixnames_tests.cpp. r=#nss-reviewers 2 years ago John Schanck [:jschanck] 48 bytes, text/x-phabricator-request		Details \| Review

John Schanck [:jschanck]

Assignee

Description

•

2 years ago

•

Edited

Builds broken: https://treeherder.mozilla.org/jobs?repo=try&revision=b1ca6914f8ffc3a72620a3dda51658c6f835eb32&selectedTaskRun=AlsAhCYcSvqeCXC4BdpdqA.0

John Schanck [:jschanck]

Assignee

Comment 1

•

2 years ago

Attached file Bug 1852179 - avoid implicit conversion for ByteString. r=#nss-reviewers — Details

John Schanck [:jschanck]

Assignee

Comment 2

•

2 years ago

Attached file Bug 1852179 - declare string literals using char in pkixnames_tests.cpp. r=#nss-reviewers — Details

John Schanck [:jschanck]

Assignee

Comment 3

•

2 years ago

https://hg.mozilla.org/projects/nss/rev/ffcd9925814e6be140b398382c0825fd8f798cfc
https://hg.mozilla.org/projects/nss/rev/dbed9fc0522a94ce9ec81b9369f08afbb5e812e0

Status: NEW → RESOLVED

Closed: 2 years ago

Resolution: --- → FIXED

You need to log in before you can comment on or make changes to this bug.

Bugzilla

Bad implicit conversion constructor in pkixtestutil.h

Categories

(NSS :: Libraries, defect, P1)

Tracking

(Not tracked)

People

(Reporter: jschanck, Assigned: jschanck)

References

(Regression)

Details

(Keywords: regression)

Crash Data

Security

(public)

User Story

Attachments

(2 files)

Description

Comment 1

Comment 2

Comment 3

Attachment

General

Description

File Name

Content Type