1852209 - Switch to bitflags 2

Status: RESOLVED FIXED

(Core :: General, task)

Description

[Mike Hommey [:glandium]]

We currently are using a fake bitflags 2, derived from bitflags 1. More and more crates are using it, and we're at a sweet spot where flipping things around makes sense: using a fake bitflags 1, derived from bitflags 2.

There are "only" 6 crates that cause problems:

• dom, style and selectors, all handled in bug 1852208
• cubeb-core, which is handled with https://github.com/mozilla/cubeb-rs/pull/84
• minidump-common, which is handled with https://github.com/rust-minidump/rust-minidump/pull/869
• webrender, which needs a trivial oneliner that will be handled in this bug.

Comment 1

[Mike Hommey [:glandium]]

One more: audio-mixer, handled with https://github.com/mozilla/audio-mixer/pull/15

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1852209 - Update cubeb-core to 0.10.4.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1852209 - Avoid using bitflags internals in webrender.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1852209 - Fixup servo for bitflags 2 after bug 1792501.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1852209 - Switch to bitflags 2

We currently are using a fake bitflags 2, derived from bitflags 1. More
and more crates are using it, and we're at a sweet spot where flipping
things around makes sense: using a fake bitflags 1, derived from
bitflags 2.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db0f75cd5932
Update cubeb-core to 0.10.4. r=media-playback-reviewers,supply-chain-reviewers,kinetik
https://hg.mozilla.org/integration/autoland/rev/7f6b68acf7b6
Avoid using bitflags internals in webrender. r=gfx-reviewers,gw
https://hg.mozilla.org/integration/autoland/rev/d97182f92202
Fixup servo for bitflags 2 after bug 1792501. r=emilio
https://hg.mozilla.org/integration/autoland/rev/b3d4dd6d5b43
Switch to bitflags 2 r=supply-chain-reviewers,emilio

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/db0f75cd5932
https://hg.mozilla.org/mozilla-central/rev/7f6b68acf7b6
https://hg.mozilla.org/mozilla-central/rev/d97182f92202
https://hg.mozilla.org/mozilla-central/rev/b3d4dd6d5b43