1852286 - [wpt-sync] Sync PR 41880 - Update and move old CSS2.1 counters tests to wpt

Status: RESOLVED FIXED

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 41880 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41880
Details from upstream follow.

Daniil Sakhapov <[e-mail]> wrote:

Update and move old CSS2.1 counters tests to wpt

Test changes are due to the:
https://drafts.csswg.org/css-lists/#inheriting-counters
which says that we inherit the counter from sibling, only
if element counters does not already contain a counter
with the same name. So, for all the \<span>s which
does not have counter-reset, we take the counter from
\<div id="test">, therefor when using counter() and counters()
they have only one counter to show. Also, previous tests were
taking the value of the counter from the wrong source (counter with
same name, not same name + same creator).

Bug: 990657
Change-Id: Id2f7c98d5d60b9f4dd8669b0e349c295b01a5f3d

Reviewed-on: https://chromium-review.googlesource.com/4831155
WPT-Export-Revision: ef5b83dbb6392d981007af8b791439778ab18a18

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e35899f1849667447acc7e54e23c31f439299107

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 8 tests

Status Summary

Firefox

PASS: 7
FAIL: 1

Chrome

FAIL: 8

Safari

FAIL: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-lists/counter-004.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/833cf2c9cbfd
[wpt PR 41880] - Update and move old CSS2.1 counters tests to wpt, a=testonly
https://hg.mozilla.org/integration/autoland/rev/cfeb56db07ba
[wpt PR 41880] - Update wpt metadata, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/833cf2c9cbfd
https://hg.mozilla.org/mozilla-central/rev/cfeb56db07ba