1852304 - When adding multiple meeting attendees, they are not aligned in a cell

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Arthur K. (he/him)]

Attachment: attendees-not-in-cells.png

Seen in TB 115.2.0 Portable.

STR:

1. Create a new meeting invite and begin inviting a lot of attendees

Actual results:

1. Some attendees will not be aligned in their cell and it will appear almost as a strike-through (see image)

Expected results:

1. Attendees will be aligned in their cell and it will not appear as a strike-through (see image)

Comment 1

[Merome]

Still present on 115.8.1

Comment 2

[adrien.rybarczyk]

The problem is due to the margin 0 of the class plain, which is assigned to each input.

Comment 3

[Alessandro Castellani [:aleca]]

Richard, would you have time to take a look at this?

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Bug 1852304 - Fix the cell height of the attendee dialog list. r=#thunderbird-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2a3935217606
Fix the cell height of the attendee dialog list. r=mkmelin,freaktechnik

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 9396533 [details]
Bug 1852304 - Fix the cell height of the attendee dialog list. r=#thunderbird-reviewers

[Approval Request Comment]
User impact if declined: attendees not correctly aligned when many of them are in the list
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Richard Marti (:Paenglab)]

Attachment: 1852304-attendee-ESR.patch

[Approval Request Comment]
User impact if declined: attendees not correctly aligned when many of them are in the list
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9396533 [details]
Bug 1852304 - Fix the cell height of the attendee dialog list. r=#thunderbird-reviewers

[Triage Comment]
We will let this ride the train

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9396533 [details]
Bug 1852304 - Fix the cell height of the attendee dialog list. r=#thunderbird-reviewers

[Triage Comment]
Actually, let's take this one.
And then to 115.11.0.

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 126.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/bb62a20b57eb

Comment 11

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Managed to reproduce this issue with the affected build from 2023-09-08 (119.0a1-20230908214338).

Confirming this issue as verified fixed using 126.0b2(20240429201016) with macOS 14, Windows 11 and Ubuntu 22.

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9397311 [details] [diff] [review]
1852304-attendee-ESR.patch

[Triage Comment]
Approved for esr115

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 115.11.0:
https://hg.mozilla.org/releases/comm-esr115/rev/3eb7a47e645b