Closed Bug 1852333 Opened 10 months ago Closed 9 months ago

Detect hevc inband config changes

Tracking

()

Status:

RESOLVED FIXED

Milestone:

120 Branch

Tracking Flags:

Tracking

Status

firefox120

---

fixed

People

(Reporter: alwu, Assigned: alwu)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

Bug 1852333 - part2 : detect config change for HEVC stream. 10 months ago Alastor Wu [:alwu] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1852333 - part3 : separate different errors for debug purpose. 9 months ago Alastor Wu [:alwu] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1852333 - part4 : check the sample's mimetype to ensure only accept correct type for parsing. 9 months ago Alastor Wu [:alwu] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1852333 - part1 : fix incorrect macro. 9 months ago Alastor Wu [:alwu] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1852333 - part5 : add inband config test. 9 months ago Alastor Wu [:alwu] 48 bytes, text/x-phabricator-request		Details \| Review

Alastor Wu [:alwu]

Assignee

Description

•

10 months ago

No description provided.

Alastor Wu [:alwu]

Assignee

Comment 1

•

10 months ago

Attached file Bug 1852333 - part2 : detect config change for HEVC stream. — Details

Depends on D187310

Alastor Wu [:alwu]

Assignee

Updated

•

10 months ago

Assignee: nobody → alwu

Phabricator Automation

Updated

•

9 months ago

Attachment #9352289 - Attachment description: Bug 1852333 - part? : detect config change for HEVC stream. → WIP: Bug 1852333 - part1 : detect config change for HEVC stream.

Alastor Wu [:alwu]

Assignee

Comment 2

•

9 months ago

Attached file Bug 1852333 - part3 : separate different errors for debug purpose. — Details

Depends on D187805

Alastor Wu [:alwu]

Assignee

Comment 3

•

9 months ago

Attached file Bug 1852333 - part4 : check the sample's mimetype to ensure only accept correct type for parsing. — Details

Depends on D189685

Alastor Wu [:alwu]

Assignee

Comment 4

•

9 months ago

Attached file Bug 1852333 - part1 : fix incorrect macro. — Details

READ_IN_RANGE_OR_RETURN causes incorrectly read bits multiple times,
so we remove it and modify the other macros to ensure that read bits
would only be triggered once.

Phabricator Automation

Updated

•

9 months ago

Attachment #9352289 - Attachment description: WIP: Bug 1852333 - part1 : detect config change for HEVC stream. → Bug 1852333 - part2 : detect config change for HEVC stream.

Phabricator Automation

Updated

•

9 months ago

Attachment #9355937 - Attachment description: WIP: Bug 1852333 - part2 : separate different errors for debug purpose. → Bug 1852333 - part3 : separate different errors for debug purpose.

Phabricator Automation

Updated

•

9 months ago

Attachment #9355938 - Attachment description: WIP: Bug 1852333 - part3 : check the sample's mimetype to ensure only accept correct type for parsing. → Bug 1852333 - part4 : check the sample's mimetype to ensure only accept correct type for parsing.

Alastor Wu [:alwu]

Assignee

Comment 5

•

9 months ago

Attached file Bug 1852333 - part5 : add inband config test. — Details

Phabricator Automation

Updated

•

9 months ago

Attachment #9356262 - Attachment description: Bug 1852333 - part1 : fix incorrect marco. → Bug 1852333 - part1 : fix incorrect macro.

Pulsebot

Comment 6

•

9 months ago

Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/20adde96b25e
part1 : fix incorrect macro. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/2bb824410bef
part2 : detect config change for HEVC stream. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/9eb0f31b6cfb
part3 : separate different errors for debug purpose. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/9cb04018dcac
part4 : check the sample's mimetype to ensure only accept correct type for parsing. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/259b6ccddace
part5 : add inband config test. r=media-playback-reviewers,padenot

Atila Butkovits

Comment 7

•

9 months ago

Backed out for causing bustages at H265.cpp.

Backout link: https://hg.mozilla.org/integration/autoland/rev/97d412cf7a31602d9485ebc549b56aed797523e9

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=259b6ccddace10f5d193b8115ff03812c2ae5110&selectedTaskRun=HFLQIBvMT3Su3Da3XnV-Pg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=431398626&repo=autoland&lineNumber=17771

Flags: needinfo?(alwu)

Alastor Wu [:alwu]

Assignee

Updated

•

9 months ago

Flags: needinfo?(alwu)

Pulsebot

Comment 8

•

9 months ago

Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ee2c23cc0a50
part1 : fix incorrect macro. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/2d92dd455f19
part2 : detect config change for HEVC stream. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/a4b9a5ac9fec
part3 : separate different errors for debug purpose. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/ccf4b32b18bc
part4 : check the sample's mimetype to ensure only accept correct type for parsing. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/c7a5969f8559
part5 : add inband config test. r=media-playback-reviewers,padenot

Noemi Erli[:noemi_erli]

Comment 9

•

9 months ago

Backed out 5 changesets (Bug 1852333) for causing failures in test_hevc_playback.html CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=L0X24LoISoaEsDVmV5_Vcw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=c7a5969f8559dbbda1582362b64545a33803261e

Log: https://treeherder.mozilla.org/logviewer?job_id=431412846&repo=autoland&lineNumber=6169

Backout: https://hg.mozilla.org/integration/autoland/rev/f0a9f12e9bfc64400ebbcffb024867cb43dde998

Flags: needinfo?(alwu)

Alastor Wu [:alwu]

Assignee

Updated

•

9 months ago

Blocks: 1857097

Pulsebot

Comment 10

•

9 months ago

Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1de872081cfc
part1 : fix incorrect macro. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/6f7b5bf9db07
part2 : detect config change for HEVC stream. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/736f20f20d8c
part3 : separate different errors for debug purpose. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/c8a75164ac9a
part4 : check the sample's mimetype to ensure only accept correct type for parsing. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/f829ebaf7e5b
part5 : add inband config test. r=media-playback-reviewers,padenot

Alastor Wu [:alwu]

Assignee

Updated

•

9 months ago

Flags: needinfo?(alwu)

Sandor Molnar[:smolnar]

Comment 11

•

9 months ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/1de872081cfc
https://hg.mozilla.org/mozilla-central/rev/6f7b5bf9db07
https://hg.mozilla.org/mozilla-central/rev/736f20f20d8c
https://hg.mozilla.org/mozilla-central/rev/c8a75164ac9a
https://hg.mozilla.org/mozilla-central/rev/f829ebaf7e5b

Status: NEW → RESOLVED

Closed: 9 months ago

status-firefox120: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 120 Branch

Alastor Wu [:alwu]

Assignee

Updated

•

9 months ago

Blocks: 1857567

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Updated

•

9 months ago

Regressions: 1857670

Atila Butkovits

Comment 12

•

9 months ago

Backed out for causing video playback crashes (bug 1857670).

Backout link: https://hg.mozilla.org/integration/autoland/rev/5a76a1344524d7924b5abb8193f146180ae27e32

Status: RESOLVED → REOPENED

status-firefox120: fixed → ---

Flags: needinfo?(alwu)

Resolution: FIXED → ---

Target Milestone: 120 Branch → ---

Norisz Fay [:noriszfay]

Comment 13

•

9 months ago

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/e9fa7c857657

Alastor Wu [:alwu]

Assignee

Updated

•

9 months ago

Flags: needinfo?(alwu)

Pulsebot

Comment 14

•

9 months ago

Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/81fca2c97c24
part1 : fix incorrect macro. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/4989219e22b6
part2 : detect config change for HEVC stream. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/f060491321a9
part3 : separate different errors for debug purpose. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/e24d48fac8c4
part4 : check the sample's mimetype to ensure only accept correct type for parsing. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/e47d3bb7cf24
part5 : add inband config test. r=media-playback-reviewers,padenot

Cristina Horotan [:chorotan]

Comment 15

•

9 months ago

Backed out for causing mda failures at test_hevc_playback.html

Backout: https://hg.mozilla.org/integration/autoland/rev/3cda56a4c5de9f1cd99a4ded3044367a455e2729

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=88c47b43bbe63c30a00e9f3fd6af23596c610105&selectedTaskRun=H5pJQyCmQ9-6fT_ZCbchuA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=432050453&repo=autoland&lineNumber=5020

Flags: needinfo?(alwu)

Alastor Wu [:alwu]

Assignee

Updated

•

9 months ago

Flags: needinfo?(alwu)

Pulsebot

Comment 16

•

9 months ago

Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b15b2e7c785a
part1 : fix incorrect macro. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/412f97da1656
part2 : detect config change for HEVC stream. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/071a7b95f8a8
part3 : separate different errors for debug purpose. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/64b95c1ba8be
part4 : check the sample's mimetype to ensure only accept correct type for parsing. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/72491f460335
part5 : add inband config test. r=media-playback-reviewers,padenot

Sandor Molnar[:smolnar]

Comment 17

•

9 months ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/b15b2e7c785a
https://hg.mozilla.org/mozilla-central/rev/412f97da1656
https://hg.mozilla.org/mozilla-central/rev/071a7b95f8a8
https://hg.mozilla.org/mozilla-central/rev/64b95c1ba8be
https://hg.mozilla.org/mozilla-central/rev/72491f460335

Status: REOPENED → RESOLVED

Closed: 9 months ago → 9 months ago

status-firefox120: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 120 Branch

Ryan VanderMeulen [:RyanVM][PTO June 24-28]

Updated

•

8 months ago

Regressions: 1860840

You need to log in before you can comment on or make changes to this bug.