1852366 - "Dark mode images" (lower-brightness, higher contrast) photos in reader view's dark mode

Status: VERIFIED FIXED

(Toolkit :: Reader Mode, enhancement, P1)

Description

[Jeff Fortin]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

Read an article that alternates between text paragraphs and photos, with reader mode in dark mode.

Actual results:

The photos are usually big and bright, blinding you at night as they appear in the view while scrolling.

Expected results:

They should probably use this CSS filter trick (lower brightness, higher contrast?) : https://css-tricks.com/a-complete-guide-to-dark-mode-on-the-web/#aa-dark-mode-images

...at least when not hovered by the mouse and not scrolling. I guess if the mouse moves to hover over them (and not as a result of simply scrolling with the scrollwheel/touchpad), then the filter could transition to regular colors, until they get hovered out again.

Comment 1

[Jeff Fortin]

For testing purposes, here are some examples of articles with multiple photos that show up in reader mode, most of which are high-key (bright) photography:

• https://www.lapresse.ca/affaires/2023-09-08/entreprises-quebecoises/l-engouement-pour-l-achat-local-s-essouffle-t-il.php
• https://www.cbc.ca/news/business/back-to-office-mandate-september-2023-1.6949749

Comment 2

[Irene Ni]

Attachment: Bug 1852366 - Lowered brightness and increased contrast for images in reader view dark mode. r=cmkm

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51d3d025e7fa
Lowered brightness and increased contrast for images in reader view dark mode. r=cmkm,desktop-theme-reviewers

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/51d3d025e7fa

Comment 5

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 119.0a1 (2023-09-08) on Windows 10x64 by following the steps from comment 0 and examples from comment 1. The brightness is very high when using Reader view with dark mode.
The photos have a lower brightness with Firefox 123.0b2 on Windows 10x64, macOS 12 and Ubuntu 20.