1852442 - Firefox address bar pop-out has a noticeable delay in Firefox 117

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Omer]

Attachment: 2023-09-10 18-12-57.mkv

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

1. Open Firefox 117.
2. Type quickly in the adress bar.

Actual results:

The address bar pop-out (auto-suggestions or dropdown) is delayed, lagging behind the typing speed. This bug is specific to Firefox 117 and does not occur in older versions of Firefox.

Expected results:

The address bar pop-out should keep up with the typing speed of the user.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Address Bar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Marco Bonardo [:mak]]

I think this may just be a consequence of us giving heuristic results a bit more time to reply. It should not have an effect on the final outcome if you press Enter, it's basically just a visual thing.

Apart from the visual delay do you notice misbejaviors, like visiting truncated search strings or such?

Comment 3

[Omer]

(In reply to Marco Bonardo [:mak] from comment #2)

I think this may just be a consequence of us giving heuristic results a bit more time to reply. It should not have an effect on the final outcome if you press Enter, it's basically just a visual thing.

Apart from the visual delay do you notice misbejaviors, like visiting truncated search strings or such?

It seems to be just a visual delay.

Comment 4

[Marco Bonardo [:mak]]

I see some possibilities here:

1. we add a new notification to the controller that will update the view heuristic on input. This would probably save some resources, though the view must be able to update in-place the various heuristic result types
2. maybe we just move the heuristic waiting to the event bufferer and revert to the 16ms timer, that moves us back to the previous update system, the view may flicker a bit more while results arrive, I don't know if that may have other consequences.

While I'm not actively working on this, I can attach a WIP patch with an idea to implement the latter, as inspiration. It requires a lot more testing though.

Comment 5

[Marco Bonardo [:mak]]

Attachment: WIP: Bug 1852442 - Address Bar delay

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1816572

Comment 7

[Donal Meehan [:dmeehan]]

:daleharvey we are in the final week of beta for F119. Do we expect anything for this for Fx119?

Comment 8

[Dale Harvey (:daleharvey)]

Hi, I am working on a patch at the moment but I cant say that it will be done for this week, its also not a particularly simple patch so it may not be one we want to rush in

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1816572

Comment 10

[Dale Harvey (:daleharvey)]

Attachment: Bug 1852442 - Remove delay for heuristic result. r=mak

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7b2d7bd13af
Remove delay for heuristic result. r=mak

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e7b2d7bd13af