1852461 - crashtest 1830206.html loads wrong media resource url

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task)

Description

[Karl Tomlinson (:karlt)]

Correcting the src attribute for the media resource leads to ReferenceError: v is not defined.
Using a.play instead appears to play successfully and so "reftest-wait" is not removed.

Paul, what was intended here?

Comment 1

[Paul Adenot (:padenot)]

Interesting, it doesn't play here on macOS and errors out.

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1852461 - Fix broken crashtest landed in bug 1830206. r?karlt

Comment 3

[Paul Adenot (:padenot)]

https://treeherder.mozilla.org/jobs?repo=try&revision=f6164f5fb26ee0f05340023ea4335320861b1123, we'll see on other OSes.

Comment 4

[Paul Adenot (:padenot)]

Interestingly, this seems to play everywhere, but it errors here on an Apple Silicon machine:

[RDD 12679, Unnamed thread 1053725c0] WARNING: VideoToolbox decoder returned an error: file /Users/padenot/src/trees/mozilla-unified/dom/media/platforms/apple/AppleVTDecoder.cpp:336
[Child 12678, MediaSupervisor #1] WARNING: NS_ERROR_DOM_MEDIA_DECODE_ERR (0x806e0004) - void mozilla::AppleVTDecoder::OnDecodeError(OSStatus): OnDecodeError:ffffcd93: file /Users/padenot/src/trees/mozilla-unified/dom/media/MediaFormatReader.cpp:1776
[Child 12678, MediaSupervisor #1] WARNING: NS_ERROR_DOM_MEDIA_DECODE_ERR (0x806e0004) - void mozilla::AppleVTDecoder::OnDecodeError(OSStatus): OnDecodeError:ffffcd93: file /Users/padenot/src/trees/mozilla-unified/dom/media/MediaFormatReader.cpp:1776
[Child 12678, MediaDecoderStateMachine #1] WARNING: Decoder=10a208d00 Decode error: NS_ERROR_DOM_MEDIA_DECODE_ERR (0x806e0004) - void mozilla::AppleVTDecoder::OnDecodeError(OSStatus): OnDecodeError:ffffcd93: file /Users/padenot/src/trees/mozilla-unified/dom/media/MediaDecoderStateMachineBase.cpp:166

this is not that surprising because it's an invalid h264 file and is decoded with different implementations (hw/sw) for each OS/version/achitecture/gpu etc.

Comment 5

[Paul Adenot (:padenot)]

For reference, ffprobe outputs the following when ran on this file:

[mov,mp4,m4a,3gp,3g2,mj2 @ 0x12b605000] STSC entry 1 is invalid (first=20 count=8 id=1)
[mov,mp4,m4a,3gp,3g2,mj2 @ 0x12b605000] stream 1, contradictionary STSC and STCO
[mov,mp4,m4a,3gp,3g2,mj2 @ 0x12b605000] error reading header
dom/media/test/crashtests/1830206.mp4: Invalid data found when processing input

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52449f367333
Fix broken crashtest landed in bug 1830206. r=karlt

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/52449f367333