1852623 - Fix tab reordering animation when dragging first item in list mode

Status: VERIFIED FIXED

(Fenix :: Tabs, defect, P3)

Description

[Alexandru Putanu [:aputanu]]

When dragging up to the first tab in list mode, the list won't scroll to it. This can be fixed by replacing scrollBy with scrollToItem in ReorderableList.kt.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1852623 - Fix list tab reordering animation when dragging first element (#3599)

Comment 2

[BMO Github Automation]

Authored by https://github.com/Alexandru2909
https://github.com/mozilla-mobile/firefox-android/commit/ba12d90db94a8aa4e142352896de898273e03edf
[main] Bug 1852623 - Fix list tab reordering animation when dragging first element

Comment 3

[Lorand Janos]

Managed to reproduce the issue on yesterday's Nightly (2023-09-13).

Verified as fixed on the latest Nightly build (2023-09-14). The list scrolls all the way to the top when trying to drag an tab from a lower position to the first one (or wherever needs scrolling to get) in list view.

Device used: Google Pixel 7 (Android 14).

Marking the ticket as verified.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:aputanu, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox118 to wontfix.

For more information, please visit BugBot documentation.

Comment 5

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1852623 - Fix list tab reordering animation when dragging first element (backport #3599) (#3711)