1852700 - "Couldn't execute privileged script named undefined" in browsertime profile run on automation

Status: RESOLVED WONTFIX

(Testing :: Performance, defect, P2)

Description

[Tooru Fujisawa [:arai] (away until 08-17)]

Steps:

1. open treeherder https://treeherder.mozilla.org/jobs?repo=mozilla-central&searchStr=nytimes&revision=490db6af9df770b2ccc4bba6b10d0ce9ead57034&selectedTaskRun=fhPg6XU4RVuvx1QddKpFAw.0
2. select browsertime job (nytimes in the above)
3. click "Trigger performance profile" or "Re-trigger performance profile"
4. wait for the -p job

Result:
the profile job fails with the following:

https://treeherder.mozilla.org/jobs?repo=mozilla-central&searchStr=nytimes&revision=490db6af9df770b2ccc4bba6b10d0ce9ead57034&selectedTaskRun=JHWhpeq1QaighlAH8UgJiw.0

https://treeherder.mozilla.org/logviewer?job_id=428803334&repo=mozilla-central&lineNumber=1579

[task 2023-09-12T05:37:39.704Z] 05:37:39    ERROR -  raptor-browsertime Error: Browsertime failed to run
[task 2023-09-12T05:37:39.771Z] 05:37:39 CRITICAL -  raptor-browsertime Critical: Couldn't execute privileged script named undefined error:ScriptTimeoutError: Timed out after 120000 ms

Comment 1

[Greg Mierzwinski [:sparky]]

:arai, if you look at the autoland push that contains the job that triggered the alert, you'll be able to find profiles in the artifacts tab or through the Open in Firefox Profiler button the performance tab: https://treeherder.mozilla.org/jobs?repo=autoland&selectedJob=427707468&group_state=expanded&revision=0b374bcf3727e39fb3a5bbcc66005c9dc4690f8d&searchStr=nytime

If you retrigger the task I linked, you'll be able to generate new profiles.

:kshampur/:canova, what do you think about disabling that button in treeherder when a task already has a profile?

Comment 2

[Tooru Fujisawa [:arai] (away until 08-17)]

Thanks :) I didn't realize it requires retriggering the entire job to generate more profiles.

Comment 3

[Nazım Can Altınova [:canova]]

I don't think disabling this button is the best way forward. Mainly because extra_profiler_run and gecko_profile runs are different. I can imagine a use case where a user might want to get more profiles from the CI, that's why re-trigger button is I think still useful. gecko_profiler runs will also give you more profiles in one run, which can come in handy, whereas extra_profiler_run is limited to only one run.

But I think we can make the "Open in Firefox Profiler" more prominent, so people can find this button easily. And make the re-trigger button less prominent, so only people who really want use it actually use it.

Also, looks like the gecko_profiler runs are failing for this task which is not great. I think we should fix that instead. We can either reduce the cycles in this profile when gecko_profile is enabled, or we can increase the timeout duration (I think increasing the timeout duration is very common in our profiling tasks currently so I would prefer that one).

Comment 4

[Kash Shampur [:kshampur] ⌚EST]

agreed with points made by :canova

Comment 5

[Greg Mierzwinski [:sparky]]

:kshampur, do you know if this is still an issue?

Comment 6

[Kash Shampur [:kshampur] ⌚EST]

Sorry for the delayed response. After reviewing this bug, the original issue from comment 0 I don't think happens anymore (or at least, it would be intermittent... have not seen any reports in the past 2 years). And I've confirmed by triggering profiling runs on a few tests the error isn't hit anymore.

I think we can close this as WONTFIX.

The missing script name error can be confusing... I believe that is something to add upstream in browsertime though.