Closed Bug 1852755 Opened 1 year ago Closed 1 year ago

Move Ion safepoint encoding off-thread

Categories

(Core :: JavaScript Engine: JIT, task, P1)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
119 Branch
Tracking Flags:
Tracking Status
firefox119 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [sp3])

Attachments

(1 file)

Bug 1852755 - Call encodeSafepoints as part of off-thread codegen instead of on the main thread. r?iain!
48 bytes, text/x-phabricator-request
Details | Review

I was just looking at a profile where CodeGeneratorShared::encodeSafepoints took a pretty large amount of time. This is called as part of linking on the main thread, but can be done off-thread.

This was on M1. It's probably less of an issue on x64 because it doesn't have as many registers.

This was showing up in profiles on M1. It likely affects arm64 more than x64
because it has so many registers.

Blocks: sm-opt-jits
Severity: -- → N/A
Priority: -- → P1
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4bd4176ffec7 Call encodeSafepoints as part of off-thread codegen instead of on the main thread. r=iain

https://hg.mozilla.org/mozilla-central/rev/4bd4176ffec7

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox119: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
Whiteboard: [sp3]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: