1852775 - RTX SSRCs are not being configured correctly

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P2)

Description

[Byron Campen [:bwc]]

This code is spitting out the RTX SSRCs in a random order:

https://searchfox.org/mozilla-central/rev/64eef6b342bca86930caf3ba403c0f8ce621b474/dom/media/webrtc/jsep/JsepTrack.h#172-174

While this code is negotiating them in the way one would expect:

https://searchfox.org/mozilla-central/rev/64eef6b342bca86930caf3ba403c0f8ce621b474/dom/media/webrtc/jsep/JsepTrack.cpp#350-353

We need to be iterating over the SSRCs, and using those to grab the RTX SSRCs in the right order.

Comment 1

[Byron Campen [:bwc]]

Attachment: Bug 1852775: Test case for bug. r?mjf

Verify that RTX SSRCs are in the same order on the JsepTrack as they are in SDP

Comment 2

[Byron Campen [:bwc]]

Attachment: Bug 1852775: Fix bug where JsepTrack::GetRtcSsrcs got the order wrong. r?mjf

Depends on D188040

Comment 3

[Byron Campen [:bwc]]

Try looks normal:

https://treeherder.mozilla.org/jobs?repo=try&revision=ff66c5e2e72ceff62b09eec6166e3b7f878e1f40
https://treeherder.mozilla.org/jobs?repo=try&revision=de5b132208cb25bd954530f39f1cd9de86327681
https://treeherder.mozilla.org/jobs?repo=try&revision=0972e215fb1408404f918fb8f5bf8afc8c538bac

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b09f4fc219b0
Test case for bug. r=mjf
https://hg.mozilla.org/integration/autoland/rev/d238756ba039
Fix bug where JsepTrack::GetRtcSsrcs got the order wrong. r=mjf

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b09f4fc219b0
https://hg.mozilla.org/mozilla-central/rev/d238756ba039