1852838 - Make use of SitePermissions module in Data Manager

Status: RESOLVED FIXED

(SeaMonkey :: Passwords & Permissions, task)

Description

[Ian Neal]

At the moment there is some code and entity duplication between the permissions part of Data Manager and the SitePermissions module, so look at reducing that.

Comment 1

[Ian Neal]

Attachment: 1852838-dataman-perms-25318.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.18
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: Removal of 15 and addition of 7 strings

Removed duplication in getting of permission labels and getting the default permission for a type.

Comment 2

[Ian Neal]

One thing that might need changing is the string for:
permission.object.label

At the moment its is Run Plugins and I'm fairly sure it's not anything to do with plugins in the expected sense.

Comment 3

[Frank-Rainer Grahl (:frg)]

SitePermissions seems to not know about:
permission.allowXULXBL.label = Use XUL/XBL Markup
permission.login-saving.label = Save Passwords
permission.object.label = Run Plugins
permission.offline-app.label = Offline Web Applications
permission.script.label = Run Scripts
permission.stylesheet.label = Load Stylesheets
permission.trackingprotection.label = Tracking Activity

esr60 version: https://searchfox.org/mozilla-esr60/source/browser/modules/SitePermissions.jsm#578

It would return a default permission unknown at least. Did you test one of these?

Comment 4

[Ian Neal]

(In reply to Frank-Rainer Grahl (:frg) from comment #3)

SitePermissions seems to not know about:
permission.allowXULXBL.label = Use XUL/XBL Markup
permission.login-saving.label = Save Passwords
permission.object.label = Run Plugins
permission.offline-app.label = Offline Web Applications
permission.script.label = Run Scripts
permission.stylesheet.label = Load Stylesheets
permission.trackingprotection.label = Tracking Activity

esr60 version: https://searchfox.org/mozilla-esr60/source/browser/modules/SitePermissions.jsm#578

It would return a default permission unknown at least. Did you test one of these?

Yes, I tested adding a permission in Data Manager both with and without the patch and compared behaviour to check nothing had changed.

Comment 5

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9352797 [details] [diff] [review]
1852838-dataman-perms-25318.patch

LGTM

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dfb79d1a9e8d
Make use of SitePermissions module in Data Manager. r=frg

Comment 7

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/aaa1e929d52b999b02e9b096846e2eacd326c0f6
Make use of SitePermissions module in Data Manager. r=frg a=frg