1852979 - Avoid unecessary React updates in SourcesTreeItem

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Alexandre Poirot [:ochameau]]

The following arrow function passed as component property will cause react updates on any state change:
https://searchfox.org/mozilla-central/rev/1cae9ca7cc7d17cfc92088dfc68e5ff391128caa/devtools/client/debugger/src/components/PrimaryPanes/SourcesTreeItem.js#242-250

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1852979 - [devtools] Avoid unecessary React updates in SourcesTreeItem

This property wasn't used and forced react updates as the arrow function
will cause the property to change on any state change.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed783efaebef
[devtools] Avoid unecessary React updates in SourcesTreeItem r=bomsy

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ed783efaebef

Comment 4

[Julian Descottes [:jdescottes]]

== Change summary for alert #39623 (as of Wed, 20 Sep 2023 21:33:56 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
73%	damp custom.jsdebugger.adding-sources.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	1,624.99 -> 444.26
73%	damp custom.jsdebugger.adding-sources.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	1,642.65 -> 450.37
64%	damp custom.jsdebugger.adding-sources.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender-sw	1,170.71 -> 419.93
64%	damp custom.jsdebugger.adding-sources.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender	1,175.14 -> 422.12
33%	damp custom.jsdebugger.stepOver.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	433.14 -> 290.93
...	...	...	...	...
2%	damp cold.jsdebugger.open.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender-sw	477.95 -> 467.87

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=39623