Enable Marionette tests with Wayland
Categories
(Firefox Build System :: Task Configuration, task)
Tracking
(Not tracked)
People
(Reporter: whimboo, Unassigned)
References
(Depends on 3 open bugs, Blocks 1 open bug)
Details
Attachments
(2 obsolete files)
Similar to bug 1850549 for Firefox UI tests it would be great to get the Marionette (Mn) tests running on Wayland as well. This would allow us to have an environment which is much closer to our WebDriver users in real life.
|
Reporter | |
Comment 1•1 year ago
|
||
|
|
Reporter | |
Comment 2•1 year ago
|
||
There are test failures visible for those tests that move the window. Hereby the minimal x position of the window now seems to be 26px. I wonder if with Ubuntu 22.04 (and Wayland) we have a left menu visible, or do we still turn this off?
Andrew, do you know?
|
||
Updated•1 year ago
|
|
|
||
Comment 3•1 year ago
|
||
I do see that locally:
./mach test testing/marionette/harness/marionette_harness/tests/unit/test_window_rect.py
Looks like Wayland issue.
|
|
||
Updated•1 year ago
|
|
|
Reporter | |
Comment 4•1 year ago
|
||
Martin, can you please file a new bug specific to this Wayland issue? This bug is really to get the Marionette job running under Wayland. Please mark this bug being blocked by the Wayland bug. Thanks.
|
|
Reporter | |
Updated•1 year ago
|
|
|
||
Comment 5•1 year ago
|
||
|
||
Updated•1 year ago
|
|
|
||
Comment 6•1 year ago
|
||
Depends on D190317
|
|
||
Updated•1 year ago
|
|
|
||
Comment 7•1 year ago
|
||
(In reply to Henrik Skupin [:whimboo][⌚️UTC+2] from comment #4)
Martin, can you please file a new bug specific to this Wayland issue? This bug is really to get the Marionette job running under Wayland. Please mark this bug being blocked by the Wayland bug. Thanks.
Okay, filed as Bug 1857571
|
|
||
Comment 8•1 year ago
|
||
Comment on attachment 9357108 [details]
Bug 1852986 [Linux] Add moz:wayland system capability for tests r?ahal
Revision D190317 was moved to bug 1857571. Setting attachment 9357108 [details] to obsolete.
|
|
||
Comment 9•1 year ago
|
||
Comment on attachment 9357110 [details]
Bug 1852986 [Linux] Don't test window positioning on Wayland r?ahal
Revision D190318 was moved to bug 1857571. Setting attachment 9357110 [details] to obsolete.
|
|
Reporter | |
Comment 10•1 year ago
|
||
Hm, it is unfortunate that Wayland doesn't support resizing and positioning a window. It will put us into trouble if Wayland would be the only WindowManager that we could use in CI for testing. We definitely cannot loose the test coverage for positioning and resizing windows on Linux. Andrew, will there be an optional non-Wayland test machine be available for testing?
|
|
||
Comment 11•1 year ago
|
||
(In reply to Henrik Skupin [:whimboo][⌚️UTC+2] from comment #10)
Hm, it is unfortunate that Wayland doesn't support resizing and positioning a window. It will put us into trouble if Wayland would be the only WindowManager that we could use in CI for testing. We definitely cannot loose the test coverage for positioning and resizing windows on Linux. Andrew, will there be an optional non-Wayland test machine be available for testing?
Window resizing is supported of course. You set window size and wayland compositor places it automatically on screen. It can be moved by user etc. but application itself can't change toplevel window position.
Popup windows can be positioned relatively to its parent so menu/popups works as usual. Popup constraints (place popup inside screen area) is managed by wayland by extra call where relative popup coordinates is send to application after placement request.
|
||
Comment 12•1 year ago
|
||
(In reply to Henrik Skupin [:whimboo][⌚️UTC+2] from comment #10)
Hm, it is unfortunate that Wayland doesn't support resizing and positioning a window. It will put us into trouble if Wayland would be the only WindowManager that we could use in CI for testing. We definitely cannot loose the test coverage for positioning and resizing windows on Linux. Andrew, will there be an optional non-Wayland test machine be available for testing?
Yeah, I mean at least for the foreseeable future. As long as a significant portion of users are using X11, I imagine we'll keep a test platform around for them. I guess eventually the number of X11 users will be too small to justify spending CI dollars on, but I can't imagine that happening anytime soon.
|
|
Reporter | |
Comment 13•1 year ago
|
||
(In reply to Andrew Halberstadt [:ahal] from comment #12)
Yeah, I mean at least for the foreseeable future. As long as a significant portion of users are using X11, I imagine we'll keep a test platform around for them. I guess eventually the number of X11 users will be too small to justify spending CI dollars on, but I can't imagine that happening anytime soon.
That means that we could run Mn jobs by default with the Wayland worker, and maybe on mozilla-central or very rarely on autoland with the X11 worker?
|
|
Reporter | |
Comment 14•21 days ago
|
||
Sasha, I assume we also need to block this bug on both other issues that you noticed, is that correct?
|
||
Comment 15•21 days ago
|
||
(In reply to Henrik Skupin [:whimboo][⌚️UTC+2] from comment #14)
Sasha, I assume we also need to block this bug on both other issues that you noticed, is that correct?
I don't think so. From what I can see, we don't have the marionette tests for maximization and minimization of the window (at least there are no related failures).
|
|
Reporter | |
Comment 16•21 days ago
|
||
Alright. I just pushed a try build to see how it actually looks like with Wayland enabled:
https://treeherder.mozilla.org/jobs?repo=try&revision=d7d6eb0c94c3165b70ba573caf827779b0c8c931
|
|
Reporter | |
Comment 17•21 days ago
|
||
(In reply to Henrik Skupin [:whimboo][⌚️UTC+2] from comment #16)
Alright. I just pushed a try build to see how it actually looks like with Wayland enabled:
https://treeherder.mozilla.org/jobs?repo=try&revision=d7d6eb0c94c3165b70ba573caf827779b0c8c931
It shows two perma failures that need to be addressed before we can enable Mn Wayland jobs by default.
Description
•