1853024 - HW accelerated video failed to play

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

HW accelerated video clip https://twitter.com/bezig101/status/1697934645386690904?
failed to play. SW decoder works fine. Looks like we fail to fallback to SW decode.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Looks related to twitter site. If the clip is played locally it's restarted to SW decode fallback.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

May be also AMD specific, need to test on Intel.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1853024 Build PtsCorrectionContext only on libavcodec < 58 r?alwu

PtsCorrectionContext is used on libavcodec < 58 only so build it only there.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1853024 Move decode statistics to DecodeStats class and use averange decode time to detect slow decode r?alwu

Depends on D188594

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1853024 Use LIBAVCODEC_VERSION instead of FFMPEG_AV1_DECODE in IsVideoCodec() r?alwu

Don't use FFMPEG_AV1_DECODE in FFmpegDataDecoder.cpp as it's defined in FFmpegVideoDecoder.cpp file only.

Depends on D188595

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1853024 Allow to explicitly set libav log level by MOZ_AV_LOG_LEVEL env variable r?alwu

• Set libva log according to sFFmpegVideoLog/sFFmpegAudioLog by default
• Allow to override by MOZ_AV_LOG_LEVEL env variable
• Don't fiddle with LIBVA_MESSAGING_LEVEL if it's already set

Depends on D188704

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c575547ce8b
Build PtsCorrectionContext only on libavcodec < 58 r=alwu
https://hg.mozilla.org/integration/autoland/rev/6f05427591ac
Move decode statistics to DecodeStats class and use averange decode time to detect slow decode r=alwu
https://hg.mozilla.org/integration/autoland/rev/59acae352cc1
Use LIBAVCODEC_VERSION instead of FFMPEG_AV1_DECODE in IsVideoCodec() r=alwu
https://hg.mozilla.org/integration/autoland/rev/09362d9c7385
Allow to explicitly set libav log level by MOZ_AV_LOG_LEVEL env variable r=alwu

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1c575547ce8b
https://hg.mozilla.org/mozilla-central/rev/6f05427591ac
https://hg.mozilla.org/mozilla-central/rev/59acae352cc1
https://hg.mozilla.org/mozilla-central/rev/09362d9c7385

Comment 9

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-09-13 Nightly build on Ubuntu 22.
Verified as fixed on Firefox 120.0 and Nightly 121.0a1 on Ubuntu 22.