1853091 - Add artifact build validation tasks

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Mike Hommey [:glandium]]

We kind of accidentally have one such thing via the eme check for win64-aarch64, and it caught problems in the past (the most recent being bug 1851714), but that's going to go away with bug 1853088. It would be valuable to have an explicit artifact builds check.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1853091 - Split diffoscope task definitions across two files.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1853091 - Properly handle mac builds in diffoscope tasks.

We never really had such tasks, so that they failed was not visible. The
problem is that the unpack code doesn't handle symbolic links properly,
and mac builds have a symbolic link for the icon that sends to
/Applications. What we really want to unpack, though, is the
Firefox*.app/Contents/Resources directory, so do that.

While doing that, we also change the path we unpack for other platforms,
which has the side effect of removing precomplete, so we don't need to
alter. It should have been this way all along.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1853091 - Add xxd to the diffoscope docker image.

diffoscope uses it to display nicer binary diffs.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1853091 - Add artifact build validation tasks.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad1476c9ef59
Split diffoscope task definitions across two files. r=taskgraph-reviewers,jcristau
https://hg.mozilla.org/integration/autoland/rev/9d2fc12cb8e2
Properly handle mac builds in diffoscope tasks. r=taskgraph-reviewers,jcristau
https://hg.mozilla.org/integration/autoland/rev/90bbffae21ea
Add xxd to the diffoscope docker image. r=taskgraph-reviewers,jcristau
https://hg.mozilla.org/integration/autoland/rev/4e4e101b77c0
Add artifact build validation tasks. r=taskgraph-reviewers,jcristau

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d416c08d583
Fix Diffoscope failure on jogfile.json. r=glandium CLOSED TREE

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ad1476c9ef59
https://hg.mozilla.org/mozilla-central/rev/9d2fc12cb8e2
https://hg.mozilla.org/mozilla-central/rev/90bbffae21ea
https://hg.mozilla.org/mozilla-central/rev/4e4e101b77c0
https://hg.mozilla.org/mozilla-central/rev/4d416c08d583

Comment 8

[Iulian Moraru]

Backed out changeset 4d416c08d583 (bug 1853091) bug 1853874 fixed the actual underlying issue.

• Push that was backed out

• Backout link