1853255 - Text bounds incorrect for inline list items

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Morgan Reschenberg [:morgan]]

STR:

1. data:text/html,<style>ul,li { display:inline; list-style-type: none;list-style-position:inside;margin:0;padding:0; }</style><div style="background:green; max-width: 400px;">List of information: <ul><li>item one</li> | <li>item two</li> | <li>item three</li> | <li>item four</li> | <li>item five</li></ul></div>
2. Using VO, step into the list and navigate by item

Expected:
VO cursor bounds each item of the list tightly

Actual:
VO cursor is offset by the length of "List of information: " in the X direction. We construct the parent bounding box by drawing a tightly fitting rectangle over all child content. This makes the bounding box's origin X = min(x coord of each child's origin), Y= min(y coord of each child's origin). We then layout each child relative to that point.

This is broken because the actual DOM origin of the list is not computed with min(X, Y of children), it is the point at which the list begins, on the line it begins in (ie. not across lines).

I think the fix here is to compute the bounding box later and/or add any offsets we make to the original origin into the child origins.

Comment 1

[James Teh [:Jamie]]

As discussed with Morgan on Zoom, another possible fix is to make this ib-split-sibling chain case apply more broadly. Long term, this might be another reason to consider moving away from parent relative offsets and instead having offsets be relative to scroll containers, etc.

Comment 2

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1853255: Make parent relative bounds for IB-split descendants account for the parent's bounding box offset r?Jamie

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf2c8ac2f33c
Make parent relative bounds for IB-split descendants account for the parent's bounding box offset r=Jamie

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out changeset cf2c8ac2f33c (Bug 1853255) for causing failures in Browser_zero_area.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=H-pfu64wQ8mOrpfT8tyDxQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=ba&revision=cf2c8ac2f33c6120ce6219b5de00b29f886797ae

Log: https://treeherder.mozilla.org/logviewer?job_id=429755214&repo=autoland&lineNumber=4252

Backout: https://hg.mozilla.org/integration/autoland/rev/99ce25d5fce69cdcd82730acccd8bae8e987e548

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/cd0e27f1d45b
Backed out changeset cf2c8ac2f33c for causing failures in Browser_zero_area.js CLOSED TREE

Comment 6

[Iulian Moraru]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/99ce25d5fce6

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/589a7a37c2f9
Make parent relative bounds for IB-split descendants account for the parent's bounding box offset r=Jamie

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/589a7a37c2f9